From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 9CEE13856241 for ; Fri, 12 May 2023 18:40:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9CEE13856241 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 146BE1004BFF5 for ; Fri, 12 May 2023 18:40:37 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id xXgzpTJpVNX2axXgzp2k7Z; Fri, 12 May 2023 18:40:37 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=645e8825 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=P0xRbXHiH_UA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=75FAf6A6GYzAqeeAwkAA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AnL6vOaBNBMQbvjXQpgqnJBuqv9oIKGX75quLza171M=; b=OhlyhomvyfLC98l+1k+rlZyehe /JNXhY5wG8LetyntSi4PLKMLiylMcCV0zG8KHcoIQ2XT/+JWudttfo0+SonUIkRQ/RlFO5WiWnIq7 Eku5JRAhAnMzPuo9Ju9wgY1aX; Received: from 75-166-157-55.hlrn.qwest.net ([75.166.157.55]:52482 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pxXgy-000NlC-Oa; Fri, 12 May 2023 12:40:36 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Simon Marchi , Tom de Vries , Andrew Burgess , Tom Tromey Subject: Re: [PATCH] [gdb/tui] Fix tui compact-source a bit more References: <20230510132118.13761-1-tdevries@suse.de> <99abb8c4-b4c0-337f-1319-48504bf0d14a@suse.de> X-Attribution: Tom Date: Fri, 12 May 2023 12:40:36 -0600 In-Reply-To: <99abb8c4-b4c0-337f-1319-48504bf0d14a@suse.de> (Tom de Vries via Gdb-patches's message of "Thu, 11 May 2023 19:45:59 +0200") Message-ID: <87sfc12y1n.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.157.55 X-Source-L: No X-Exim-ID: 1pxXgy-000NlC-Oa X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-157-55.hlrn.qwest.net (murgatroyd) [75.166.157.55]:52482 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: >> Just wondering: it makes sense to let the user scroll down all the >> way, >> until the point where line 5 is the first line in the window. However, >> do we need to print line numbers for lines that are after the end of the >> source file? In other words, could we leave lines 6-11 blank, and >> therefore we could keep using just one digit? Tom> This demonstrator patch implements that approach. FWIW I'd be fine with this. Tom