From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 58CB23858C83 for ; Fri, 21 Apr 2023 14:01:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58CB23858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 8E31F1003FD50 for ; Fri, 21 Apr 2023 14:01:30 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id prKMpBnt8NX2aprKMpnuun; Fri, 21 Apr 2023 14:01:30 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=6442973a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dKHAf1wccvYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=byT-xXtEay_j0-HEcZYA:9 a=Cv7kCFJWy1LPoAcv5pcG:22 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XkH1M24vH2+WL9EwUsKrK1wKyrc4tJmBcG4+jONThzk=; b=s+pdMresni1zD8D/iqIrSBzCjJ QjWbaf1gyz3RZIxr7LKvwI4uDYfH3vlGsrv5lw6NVPCqiwDVafvGHBNSRcM80dEUp//Dao3wY+vT+ vYLxPYw8up4NHhQ9K9WPk1QAX; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:45562 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pprKM-001YDm-8F; Fri, 21 Apr 2023 08:01:30 -0600 From: Tom Tromey To: Manoj Gupta via Gdb-patches Cc: Manoj Gupta Subject: Re: [PATCH v2] gdb: Fix building with latest libc++ References: <20230417210730.3571996-1-manojgupta@google.com> X-Attribution: Tom Date: Fri, 21 Apr 2023 08:01:28 -0600 In-Reply-To: <20230417210730.3571996-1-manojgupta@google.com> (Manoj Gupta via Gdb-patches's message of "Mon, 17 Apr 2023 14:07:30 -0700") Message-ID: <87sfct1ghz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1pprKM-001YDm-8F X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (murgatroyd) [71.211.191.82]:45562 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Manoj" == Manoj Gupta via Gdb-patches writes: Manoj> Latest libc++[1] causes transitive include to when Manoj> or header is included. This causes Manoj> gdb to not build[2] since defines isupper/islower etc. Manoj> functions that are explicitly macroed-out in safe-ctype.h to Manoj> prevent their use. Manoj> Use the suggestion from libc++ to include internally when Manoj> building in C++ mode to avoid build errors. Manoj> Use safe-gdb-ctype.h as the include instead of "safe-ctype.h" Manoj> to keep this isolated to gdb since rest of binutils Manoj> does not seem to use much C++. Thank you for the patch. Manoj> /* After safe-ctype.h is included, we can no longer use the host's Manoj> ctype routines. Trying to do so results in compile errors. Code Manoj> that uses safe-ctype.h that wants to refer to the locale-dependent Manoj> - ctype functions must call these wrapper versions instead. */ Manoj> + ctype functions must call these wrapper versions instead. Manoj> + When compiling in C++ mode, aldo include before "safe-ctype.h" "also" Manoj> +#ifdef __cplusplus Manoj> +#include Manoj> +#endif I don't think the #ifdef is needed, anything that uses gdbsupport is also written in C++. Tom