From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by sourceware.org (Postfix) with ESMTPS id A11953858D3C for ; Tue, 7 Mar 2023 14:58:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A11953858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd33.google.com with SMTP id t129so5494021iof.12 for ; Tue, 07 Mar 2023 06:58:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1678201102; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=xqItyTGvZAAV9ThSvN4rKQ82HAG5USm3+W6MnBoc3Z0=; b=HGYNbC4qmGW1+d9BK/yn8tdu4vUdPuxYZGW+C4QCCWKGLwWFZYDnH7lNrQX9k7Z3bR g9KZhn54WMqiY+iOSPKgJUvnWBbZRLe8ELVRn/yqecZJPi+MdSHhJvZSikHepA0eYBw/ 6hhilbXFtD3fcQMUJ0etkKkikHCRKYE2yS6YmLukmwFeZpmEd6txPmmBimZFXF5B1iey DH56EhPnUOvbXgOHhujpfUo53JFMU24548ncfhavuZ7uxEWgTnsQ5U49MsTIMhTgAUgB XOPQEcA3iEtcjbIsiG1FZUplqEL3vxEk0sNBCvg8YySbn1i/2per3wW17cFFdHJVq54V zngg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678201102; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xqItyTGvZAAV9ThSvN4rKQ82HAG5USm3+W6MnBoc3Z0=; b=FDUPKcrksywelFENLFiB2B0YWqUBlPFDx1bARjV4PD72TI2/W3zOzgig6+llU/XFWO xJKuoKga6g1/zuuEdlvsD42vNZ96LV1u08EpfQ7TkC8TQUC4ZHzfSJCWHt8rGZO0s1Or BFZQNigMr3sVXUNDoIjJ+/7RP44Agm3pK7m/cAznoSz+xiF2GROuMPBqUF62haVHDnlX Ea3VpoRBE0gK04no+C5N93yTdM+61hZXIxwJgFr4jZZ26QiIZAz5FO57FoPqREipY8v4 9p/nZhaz92hOUaIs/wh22BrC0jPqIS2L3eJA89EogjUfLvo7Fn0oWBRlvCOfbkUDvFDW ZU/w== X-Gm-Message-State: AO0yUKXNmxLK5QzRd8TA4sYvAwwg47t8TbKYpYsdmg5wUbRQjS3kHf+0 MoVT2w+Ql32Z9fgTt2ky/8DC96BhQ4Cgillq5Vk= X-Google-Smtp-Source: AK7set9DNUDm7aV5obPAqBnThyZj3MY+Dvm5UFPNrT7qbbv5M10EEcjcsN05IuPtziOGJvJBwbpCpA== X-Received: by 2002:a6b:fe07:0:b0:745:4726:b228 with SMTP id x7-20020a6bfe07000000b007454726b228mr10200917ioh.17.1678201101916; Tue, 07 Mar 2023 06:58:21 -0800 (PST) Received: from murgatroyd (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id t14-20020a92ca8e000000b00322c552a706sm102119ilo.27.2023.03.07.06.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 06:58:21 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2] Ensure index cache entry written in test References: <20230306164553.1449009-1-tromey@adacore.com> X-Attribution: Tom Date: Tue, 07 Mar 2023 07:58:20 -0700 In-Reply-To: (Simon Marchi's message of "Mon, 6 Mar 2023 12:59:00 -0500") Message-ID: <87sfegsj5f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: >> + gdb_test_no_output "maintenance wait-for-index-cache" Simon> I would perhaps put this command in the run_test_with_flags proc, so Simon> that it applies to other tests as well. It shouldn't be necessary for Simon> those tests, but if there's a bug somewhere, it would make it reproduce Simon> more reliably. I made this change. It required the appended hunk as well, to avoid a duplicate test name. I'm going to check it in now. Tom @@ -203,7 +205,9 @@ proc_with_prefix test_cache_enabled_hit { cache_dir } { global expecting_index_cache_use # Just to populate the cache. - run_test_with_flags $cache_dir on {} + with_test_prefix "populate cache" { + run_test_with_flags $cache_dir on {} + } lassign [ls_host $cache_dir] ret files_before