From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id DAFA83858C66 for ; Mon, 6 Mar 2023 16:47:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DAFA83858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x434.google.com with SMTP id v16so9573831wrn.0 for ; Mon, 06 Mar 2023 08:47:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1678121259; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NVVXYBB8yvYbDwwdcUR5ATZZlbEJroHJXpoRU0s2oQ8=; b=lTrFDy8XgKbYvI+2CLIr8Iah1nbj4pohv+9ytK5YmfXaGIdfw/K6qKP1anfTaUMGnL iaUZ6AEBUdjXR7f/X6l7xgM++qmRRkTgpZWTI/K1qJ1AWv4DctTZ8H6VGenEQZQayZC3 YNfM7iR6ScSy9LiljyKTBUkY4IDGX7OK5d9BeJP+madwZhxsNVCxgopLR51sGsC11NiW XUKtANi1nhelXXbTWkoP2rvrE4BdKddZ5W/Np5EKZCtDFU0Il13ivQxs9DAVaUeHDCJ7 +GQ3OxHZsN5TvqOekViUiBTnh963XX/6KmlwVscqzg3ZweZOBQWqdBTFj7r9MZtlJOL8 jHsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678121259; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NVVXYBB8yvYbDwwdcUR5ATZZlbEJroHJXpoRU0s2oQ8=; b=N3pIGEhJDDdp7ovnsIEL2jk7EBAahy2KluJZPfLd9LR6vA/yzqdYl3JXMpPNrs+zuY kzrqVzss4bMVhf9AIQ886S+qJSU9ybtE+aL4nMHXjQ1mqCUGPYtNKvClwdsU536c2E27 UZz+2XipB3bQUO9yvrWLtutWEavHkIstvm1/svYCyxX5KOcCLn1vFE0TZmrTT/iSnF5M uNZD+M0CQVPKc7KUQ49FKssqhwlP2H+eDMkX3MtCo8MiqUf3Rqvd3gBuDSSyV78CTL9Z yl6DRYBKyd8y2DtX8VwLS3DJdeWb1iLJCvXO4XiRDTZ5zZj4KzLa/av7Bju5gEM57Zmj yOLA== X-Gm-Message-State: AO0yUKUdDcW9eptpKTXAjZhV9l6h9tF4oPMumxOOpzivje7XlPLFSAUU cvECuxEd90IIyGr6Zpk/KZfIUg== X-Google-Smtp-Source: AK7set/91h0wTM/xhCmwkoY7dljEH0g866Lt7oeNXW5+aXdsHlaLWR58tqhF96kdStGC0auZg3Zwcw== X-Received: by 2002:a5d:6a88:0:b0:2c9:a342:28ff with SMTP id s8-20020a5d6a88000000b002c9a34228ffmr7129030wru.42.1678121259721; Mon, 06 Mar 2023 08:47:39 -0800 (PST) Received: from legouguec-Precision-7550 ([2a01:e0a:253:fe0:c631:3977:93c8:296]) by smtp.gmail.com with ESMTPSA id d14-20020a056000114e00b002c57475c375sm10535624wrx.110.2023.03.06.08.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Mar 2023 08:47:39 -0800 (PST) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: gdb-patches@sourceware.org Cc: aburgess@redhat.com, tromey@adacore.com Subject: Re: [PATCH] gdb/python: Fix --disable-tui build In-Reply-To: <20230224120650.286869-1-legouguec@adacore.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Fri, 24 Feb 2023 13:06:50 +0100") References: <20230224120650.286869-1-legouguec@adacore.com> Date: Mon, 06 Mar 2023 17:47:38 +0100 Message-ID: <87sfehj07p.fsf@adacore.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: K=C3=A9vin Le Gouguec writes: > Assuming I have not missed something, this might have been an "obvious > fix"? Since no-one has complained about this so far, I figure it does > not hurt to post the patch first before pushing. I pushed this today (1d6653fd3f4), after confirming the obviousness with Tom out-of-band. > gdb/python/py-tui.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gdb/python/py-tui.c b/gdb/python/py-tui.c > index 9ce76659052..92fa0591e5c 100644 > --- a/gdb/python/py-tui.c > +++ b/gdb/python/py-tui.c > @@ -618,5 +618,7 @@ gdbpy_initialize_tui () > void > gdbpy_finalize_tui () > { > +#ifdef TUI > gdbpy_tui_window_maker::invalidate_all (); > +#endif /* TUI */ > }