From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id CC6A43858D1E for ; Tue, 14 Feb 2023 02:24:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC6A43858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x22d.google.com with SMTP id c15so11928098oic.8 for ; Mon, 13 Feb 2023 18:24:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=GmwuPlQ5uE+OitcRcd9QaLR7JL/5tkGYnUoRegC/Pg4=; b=SEn/kc7ARW5fvY0awFuProBl2LFDO0XxYGDa3LbmVFC7jp9NNLy8wR3huTUtRQWvNS fUtVk1M/YhCBH1mVO/DdCEks7ms+nj3/qr7Yv9goS9O4QPeowhO7g4ridYio7TO9FUB8 r+rawnMyxDEFhiexIAv/z9WgP43PeZMQlpL1xw0tLjGFjRbtdOMRCa4ucWcLFH+2plGh 7KIM9sfq/ou/YWq0uWCvkFIqeJzWeeMBkSGJJtPm9q4CeJ7yzLNrRcpM+xZqZBvBFhCq wwugbvPpJzPc4/BdlxuzkBbh04rKo2fFdzkqXyDMU+s9ZrfGhSYyRMRaRmqJnAiZiti9 DFcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GmwuPlQ5uE+OitcRcd9QaLR7JL/5tkGYnUoRegC/Pg4=; b=RlhyWEsoDphKKAD70naINgUFR0HLpu+VJEtMeN7GU2ORq3lfRlGYqUqIlj61qqrq8F OuqZK93W7jEQK5upvkDvUtEfhbOOkGNnf86Ao8S14B7emWukFkoyARnyw2mJKpBNeci6 rGUH2rIyFC5gpV9ExjB2DxUU3A2ha+Tz4So0VRJALuYwtgtAc5tJ1MzJK3PMa7qzZ25w HsWENXxnCp8CLqx81hftpGOXZaPOip6p/FBiapBdAuYZAu9+/1ymQEOA6JaevDSoOUZ9 ngWf/Poq3XaQnAVNQpHAEY5IyyaIMdJUQNUotgt9m6BthmLoaWqrIr8nYBXDyKGjktos A5oA== X-Gm-Message-State: AO0yUKUKHhcoHkndxick7sD+ttQXe1u+Ij7idYhQkQWPdfPuRVB3CHw7 T0IOmiwMBnFscrjv02dZkJVcuQ== X-Google-Smtp-Source: AK7set92z+mgsxlZuBB7XYOG2/Vp65p+MnlCC2f8qsxJPtewUeHJycwYOfesnhDTmKuUOxT11C7YyQ== X-Received: by 2002:a54:4519:0:b0:378:7f1d:64d7 with SMTP id l25-20020a544519000000b003787f1d64d7mr445327oil.17.1676341461854; Mon, 13 Feb 2023 18:24:21 -0800 (PST) Received: from localhost ([2804:14d:7e39:8470:30a8:4b16:405e:f37b]) by smtp.gmail.com with ESMTPSA id q203-20020acad9d4000000b0037adc5702d4sm5738338oig.38.2023.02.13.18.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 18:24:21 -0800 (PST) References: <20230213145559.46676-1-simon.marchi@polymtl.ca> <20230213145559.46676-3-simon.marchi@polymtl.ca> <873579dttn.fsf@tromey.com> User-agent: mu4e 1.8.13; emacs 28.2 From: Thiago Jung Bauermann To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] gdb/dwarf2: move some things to read.h In-reply-to: <873579dttn.fsf@tromey.com> Date: Tue, 14 Feb 2023 02:24:19 +0000 Message-ID: <87sff90yss.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Simon" =3D=3D Simon Marchi via Gdb-patches writes: > > Simon> The following 2 patches move .gdb_index and .debug_names reading c= ode to > Simon> their own file. Prepare this by exposing some things used by that= code > Simon> to read.h. > > Simon> +/* If FILE_MATCHER is NULL or if PER_CU has > Simon> + dwarf2_per_cu_quick_data::MARK set (see > Simon> + dw_expand_symtabs_matching_file_matcher), expand the CU and ca= ll > Simon> + EXPANSION_NOTIFY on it. */ > Simon> + > Simon> +bool > Simon> +dw2_expand_symtabs_matching_one > Simon> + (dwarf2_per_cu_data *per_cu, > Simon> + dwarf2_per_objfile *per_objfile, > Simon> + gdb::function_view file_mat= cher, > Simon> + gdb::function_view expansion_= notify); > > Don't we normally write "extern" in headers? IIUC =E2=80=9Cextern=E2=80=9D is only meaningful for variable and template = declarations. --=20 Thiago