public inbox for
 help / color / mirror / Atom feed
From: Andrew Burgess <>
To: Simon Marchi <>,
Subject: Re: [PATCHv2] gdb/c++: fix handling of breakpoints on @plt symbols
Date: Fri, 10 Feb 2023 19:10:30 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Simon Marchi <> writes:

>> Lets consider the 3 symbols GDB created.  If the function declaration
>> is 'void foo ()' then from the main executable we added symbols
>> '_Z3foov@plt' and '_Z3foov', while from the shared library we added
>> another symbol call '_Z3foov'.  When these are demangled they become
>> 'foo()@plt', 'foo', and 'foo' respectively.
> I think the last two should be 'foo()'?

Fixed in v3.

> I have only looked at the code, not the test.  That part LGTM.  I was
> wondering if you could add some unit tests for strncmp_iw_with_mode for
> this case though.  There are already some just below the implementation.

Thank, I added a couple of tests in v3, which I think cover all the
cases I was interested in.  Let me know what you think.


  reply	other threads:[~2023-02-10 19:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20 13:55 [PATCH] " Andrew Burgess
2023-01-20 11:48 ` [PATCHv2] " Andrew Burgess
2023-01-30 15:13   ` Andrew Burgess
2023-02-08  9:36   ` Bruno Larsen
2023-02-10 19:09     ` Andrew Burgess
2023-02-13  9:31       ` Bruno Larsen
2023-02-08 22:22   ` Simon Marchi
2023-02-10 19:10     ` Andrew Burgess [this message]
2023-02-10 19:03   ` [PATCHv3] " Andrew Burgess
2023-02-10 20:51     ` Simon Marchi
2023-02-12  6:22       ` Andrew Burgess
2023-02-13 14:14       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).