public inbox for
 help / color / mirror / Atom feed
From: Tom Tromey <>
To: Simon Marchi <>
Cc: Tom Tromey <>,  Hannes Domani <>,
	 Hannes Domani via Gdb-patches <>
Subject: Re: [PATCH] Always create a new value object in valpy_do_cast
Date: Wed, 08 Feb 2023 20:35:35 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Simon Marchi's message of "Wed, 8 Feb 2023 21:08:54 -0500")

>>>>> "Simon" == Simon Marchi <> writes:

>> I think what we probably need is to change how the value_mark API works,
>> so that it isn't relying on a value pointer being in all_values, but
>> rather return some other type/object that isn't invalidated in the same
>> way.

Simon> Is there an advantage of that value chain thing vs using value_ref_ptr
Simon> throughout?  Not replace all `value *` with value_ref_ptr, but have
Simon> functions return and accept value_ref_ptr where that makes sense.

The chain is used to implement the watchpoint semantics.  It's needed, I
think, but it would be better if it were opt-in -- that is, some caller
has to request it explicitly.  However that requires switching to
value_ref_ptr everywhere...

.. but please don't do that, I'm nearly done with a series to move value
to value.h and use methods, and it's reasonably large and would be
painful to rebase.

Meanwhile I think we have a fix for this bug, the problem is finding a
test case.  Though... the one we have does fail for Hannes so perhaps
that's enough.


  reply	other threads:[~2023-02-09  3:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2023-01-18 17:27 ` Hannes Domani
2023-01-22 17:49   ` Tom Tromey
2023-01-22 18:22     ` Hannes Domani
2023-01-22 20:50       ` Tom Tromey
2023-02-09  2:08         ` Simon Marchi
2023-02-09  3:35           ` Tom Tromey [this message]
2023-02-08 23:52   ` Tom Tromey
2023-02-09  6:06     ` Hannes Domani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).