From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by sourceware.org (Postfix) with ESMTPS id 0C0553858D1E for ; Mon, 9 Jan 2023 16:11:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C0553858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd33.google.com with SMTP id q190so4708127iod.10 for ; Mon, 09 Jan 2023 08:11:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Db6/R5AwDu7x/anMI2VmH/EAP2d7OWYdz691DSloGlk=; b=gfzVDZpV1DvpEo57o33TsKbF/AkeDWxi8RtC8fp033yJTkxPmV4wXBpqZ9MNbXW7cx WuEpNd1K8E9qEXOZC6Ag2N/8h+P2Bzer3wvQasN/rfrK2TcsD3FLCJaPqAJBnjguV5hp ybnPrYVB4gMcOvep/F5dMssZN9wElogSfJPwc4znKgt5qBLH1qyJIbI0N+g+oILI6ctR gCZipEUxLj93kkKMm13Xv5xfP/N8F6NdpiGCVErheHGMgan2b3IyR8LykpgywnYHEXG7 tFLLD1ZJzMr1e9RuR2vY7RWW7cAz3BuCiTIjrdgQqpA2oENytWvaicFtjE42MqEAvMVo IlOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Db6/R5AwDu7x/anMI2VmH/EAP2d7OWYdz691DSloGlk=; b=1xkbpZq706/MYwB1f0WDPnHhJWGKbTjwYE8OtkRKYUx/XcvJ4kEus6tIYmut4FmCC5 BAqDOlZ7IsSK6Yordj2KdlQouYc5bDqP4lrCsnOVPO0nHmFAi51ibhCVglRJJp57pCjW MJvvK9QLS7L4gKSiTksICpW/oJgi1fxbZcxBvCp28tTFG0Etlxaeu+VuLWTNB5/wcIpy 33mnXVdguDRpO5uqDCjeAslgOO+Lqq5t5NoRwlnmCZbizli7UgrFKZ/qI33grN5Wq+n8 dBqJr5hz2mBCl5IQLR93LT2ImdaV/co6E8YrDvcSumtgiybY/kQl/sSjyyElrn0sfstP 4jeQ== X-Gm-Message-State: AFqh2kqN5LItF+ZDkp5DM8nauT3xvRhcvnlTA8D2U9oWEdmrvK7nEH4X UqqMxT9ZaTxvVALAIAAa7mgfvg== X-Google-Smtp-Source: AMrXdXt3hLrHMxJ884Ad26TBFavwzGrqjRYyUkrCxNA8T60f5GHrqH382X1KcaC7dT5wOvtDzyFPCA== X-Received: by 2002:a05:6602:21d4:b0:6e9:7156:3b7a with SMTP id c20-20020a05660221d400b006e971563b7amr53743479ioc.3.1673280673284; Mon, 09 Jan 2023 08:11:13 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id q21-20020a02a315000000b0039d724c2416sm2872409jai.134.2023.01.09.08.11.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 08:11:12 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Handle range types in ax-gdb.c References: <20230104164452.1154744-1-tromey@adacore.com> <20230104164452.1154744-3-tromey@adacore.com> <37f151c2-df09-b594-b29b-ff460df9038e@simark.ca> X-Attribution: Tom Date: Mon, 09 Jan 2023 09:11:11 -0700 In-Reply-To: <37f151c2-df09-b594-b29b-ff460df9038e@simark.ca> (Simon Marchi's message of "Fri, 6 Jan 2023 16:51:32 -0500") Message-ID: <87sfgjadsw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> On 1/4/23 11:44, Tom Tromey via Gdb-patches wrote: >> A range type can usually be treated the same as its underlying integer >> type, at least for the purposes of agent expressions. This patch >> arranges for range types to be handled this way in ax-gdb.c, letting a >> somewhat larger subset of Ada expressions be compiled. Simon> Instead of stripping the range type at many places (possibly forgetting Simon> some), I wonder if this could be done systematically before, when we Simon> build the axs_values. I didn't really consider this option, but now when looking at it, it seems there are many more places that assign to 'type'. Tom