From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6EBA23858D37 for ; Mon, 9 Jan 2023 11:50:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6EBA23858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673265047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VyVZF6GKI9PB3/QiGrufU17RROhAGTWZ7OCCq5Nblbc=; b=TJ5u15NEqebT7XTjcGKlDg9AOJWle47LLILISG+47nh7Jn2mrjsaw2qbCHddRwkXdQobNq RXVshJ26HFM4uLrjSXJmpIShyWuqiOj2Mx9Hp8bynCGQ+cMdOVz57DyWy4qFelS2MHbqB1 qYalDJHrAmblSHc9jLNVSm1lArgkR2Y= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-590-IJ0EFABFMGuPvtkg0uEWWw-1; Mon, 09 Jan 2023 06:50:46 -0500 X-MC-Unique: IJ0EFABFMGuPvtkg0uEWWw-1 Received: by mail-qk1-f197.google.com with SMTP id de38-20020a05620a372600b0070224de1c6eso6341797qkb.17 for ; Mon, 09 Jan 2023 03:50:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VyVZF6GKI9PB3/QiGrufU17RROhAGTWZ7OCCq5Nblbc=; b=2JA5AOBC+IEXBM1GJhfac+Q6cFBKeC5C4zUVMTy3BcoNtBokbE5miSjgl1YpsBH514 w1v4PDzMxrdzU0hfhjL2TvsUFyDNU36Nof2A/6l9dS8Nntqgq7U8OFRwk73locyfmpXK /ctim48SdykM36hnvrQmg9BJp4qP2b2pfim8qsKUIlBvzAizVYpFpZNrLNAvLEJfzcmS 7S8DEhgmmzEUkuHYoffQpoMpCVUpZBD2/vCkMnR4XXBgUYp2fEaarSZ4KeNaE9CxDVf/ 8x1AAOai6nMwku6erVxRm5Dm3T8GV+o+BB7ye4Rej96Wfe0WG8kI4ANWikT+OWwgD+UE g2lw== X-Gm-Message-State: AFqh2kpWtNk4S4TlG+0hbEBKj8AXQ1INj2EGu0DkxiqQ6dSvL0I/MiTu jMOmYS2N2EroUcVXHHy3kd7OIC1YRN0yuzN2wfyaqkNQew1mfV7sQxjKyV9yJeU4PdTqaWirByi YRNsJ9Zs2wK3ezJaukTjy6A== X-Received: by 2002:a05:622a:4c88:b0:3a8:21a5:d93 with SMTP id ez8-20020a05622a4c8800b003a821a50d93mr102131314qtb.39.1673265045559; Mon, 09 Jan 2023 03:50:45 -0800 (PST) X-Google-Smtp-Source: AMrXdXtRPDinM5J7LeVmlvN/1TMCaFji9W5Fu7myuME3bCGoxL65RtZ42wgEj+epVPVuuRyYb1IMbQ== X-Received: by 2002:a05:622a:4c88:b0:3a8:21a5:d93 with SMTP id ez8-20020a05622a4c8800b003a821a50d93mr102131292qtb.39.1673265045253; Mon, 09 Jan 2023 03:50:45 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id u12-20020a05622a198c00b003ade7d4ad7asm752191qtc.10.2023.01.09.03.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 03:50:44 -0800 (PST) From: Andrew Burgess To: Tom Tromey , gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH] Fix crash with C++ qualified names In-Reply-To: <20221223195809.602699-1-tom@tromey.com> References: <20221223195809.602699-1-tom@tromey.com> Date: Mon, 09 Jan 2023 11:50:42 +0000 Message-ID: <87sfgkgc4t.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: > PR c++/29503 points out that something like "b->Base::member" will > crash when 'b' does not have pointer type. This seems to be a simple > oversight in eval_op_member. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29503 > --- > gdb/eval.c | 2 ++ > gdb/testsuite/gdb.cp/ambiguous.exp | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/gdb/eval.c b/gdb/eval.c > index d0a4a16ceb5..3757028b4a3 100644 > --- a/gdb/eval.c > +++ b/gdb/eval.c > @@ -1300,6 +1300,8 @@ eval_op_member (struct type *expect_type, struct expression *exp, > > case TYPE_CODE_MEMBERPTR: > /* Now, convert these values to an address. */ > + if (check_typedef (value_type (arg1))->code () != TYPE_CODE_PTR) > + arg1 = value_addr (arg1); > arg1 = value_cast_pointers (lookup_pointer_type (TYPE_SELF_TYPE (type)), > arg1, 1); > > diff --git a/gdb/testsuite/gdb.cp/ambiguous.exp b/gdb/testsuite/gdb.cp/ambiguous.exp > index 5d0d2f88b6e..65b33e89a79 100644 > --- a/gdb/testsuite/gdb.cp/ambiguous.exp > +++ b/gdb/testsuite/gdb.cp/ambiguous.exp > @@ -123,6 +123,7 @@ with_test_prefix "all fields" { > gdb_test "print n.A1::y" " = 2" > gdb_test "print n.A2::x" " = 3" > gdb_test "print n.A2::y" " = 4" > + gdb_test "print n->A2::y" " = 4" > gdb_test "print n.w" " = 5" > gdb_test "print n.r" " = 6" > gdb_test "print n.z" " = 7" LGTM. Thanks, Andrew > -- > 2.38.1