From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id B105E3858D20 for ; Sun, 25 Dec 2022 15:33:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B105E3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 770461003F8D1 for ; Sun, 25 Dec 2022 15:33:23 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 9T07pHfsPNX2a9T07pnXi3; Sun, 25 Dec 2022 15:33:23 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=63a86d43 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=sHyYjHe8cH0A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=rCVDgAmT0DQPOyZZi3kA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3wS4CbnmmfXTlOCFToXKOwO383yedr1WqgcEOsGNgsk=; b=K30RLRBBfjAnEk0ogTfmtGYJXS 0wYz4Ig+j5nxH2XMuV7KEg/UvGjQOxOioC4qG0gSSVEBVM3GrM8K2xpcSeSjTHHaj82zDgacgIGbV LspqzgXadZixXDE2PO3klVeg6; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:58982 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p9T06-001bRr-Va; Sun, 25 Dec 2022 08:33:23 -0700 From: Tom Tromey To: tdevries via Gdb-patches Cc: Tom Tromey , tdevries Subject: Re: [PATCH] Add initializers to comp_unit_head References: <20221224224435.760523-1-tom@tromey.com> <71d0815665fb2b2c4904264b023840d1@suse.de> X-Attribution: Tom Date: Sun, 25 Dec 2022 08:33:19 -0700 In-Reply-To: <71d0815665fb2b2c4904264b023840d1@suse.de> (tdevries via Gdb-patches's message of "Sun, 25 Dec 2022 08:06:53 +0000") Message-ID: <87sfh3cxc0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1p9T06-001bRr-Va X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (prentzel) [97.122.76.186]:58982 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> tdevries via Gdb-patches writes: > FWIW, I've rebased the patch attached to the PR on your patch, and I'm > left with the patch below, which makes the length field of > comp_unit_head private. > /* Return the total length of the CU described by this header. */ > - unsigned int get_length () const > + unsigned int get_length (bool include_initial = true) const > { > - return initial_length_size + length; > + unsigned int res = m_length; > + if (include_initial) > + res += initial_length_size; > + return res; I think that since the callers all statically decide which length they want, there should probably just be two methods with different names. Tom