From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 285B8385135F for ; Tue, 13 Dec 2022 15:39:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 285B8385135F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670945993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mzPTeiQMIYwawwGsUEHcS/vHj8qNZK9OzKhipRYPxd0=; b=QD4IhFIAPOJpkghRwX6coSdtRNbUD9VwgY9zUaYBXem8sPib6WC/IwTQDm+s/hkakZkXOT zGAW1EnMTtU2uhMqOK4yfVGyCIelWcW8jUVt/gfl5a4ON5SaLO1V2GgzmJRZ0ryFfwildt xrRPXX7vpXmruKqlGk7d8Jy/Nu+1B00= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-460-_DhXig9zPAStDCLcFcI09Q-1; Tue, 13 Dec 2022 10:39:52 -0500 X-MC-Unique: _DhXig9zPAStDCLcFcI09Q-1 Received: by mail-wm1-f69.google.com with SMTP id f20-20020a7bc8d4000000b003d1cda5bd6fso3178878wml.9 for ; Tue, 13 Dec 2022 07:39:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mzPTeiQMIYwawwGsUEHcS/vHj8qNZK9OzKhipRYPxd0=; b=yMlO+aU3nN9x3K65Gb1Gq+S77O6ZdM8x2t8mDcgt1HZgEvoLnnz1+CE51Bxjc3R+rT y4WbdHO7U3gjkcRwz3v7R7zrf16+OXljZAlgI5KSh2QlJ0Y1RIN/o81ovyjrBIdzTOyW Sn+PnfbtN8YVfU8C04Pqj0HU+Gr56gvl/SW3yeyWmfI47LWbkQgHyU8UI0dyOEIb6xOL 1snJBmZlzXX7AIVUOoG7tt8YSR1R6iVH7yyTLHRVojwPKYAWBaSoFbiOvCueyZVP3XjV 3CT/XddWPSv+0tsR8Ci5fyiixRA1U0doNnmFUG3ZS1g1tSWgZWgroJN3a3QKvk5/HBxO fD8g== X-Gm-Message-State: ANoB5plkaE7bV1x2HybdR/7hsnNHQ6OBu+fdNZA9y2CCRLkFyo5iMOZt DwO4ck0R+W5TW3gfx0wIt9zppIIXARssxYDKnLOW5IdA4HVKtmf9CrH2nTYrzML/Zl16GIGXcHw hMDmYAN87Rnh0CQWfnJgaiA== X-Received: by 2002:a05:600c:35c3:b0:3d2:1bf6:5796 with SMTP id r3-20020a05600c35c300b003d21bf65796mr9642689wmq.35.1670945991410; Tue, 13 Dec 2022 07:39:51 -0800 (PST) X-Google-Smtp-Source: AA0mqf5QkvA0EtCo8TFlGZP5ruCxYcwVrwdSkwmsfGU+CF4zErm9C6c44FVqXP/IhKZyZ5R/j2OjOQ== X-Received: by 2002:a05:600c:35c3:b0:3d2:1bf6:5796 with SMTP id r3-20020a05600c35c300b003d21bf65796mr9642676wmq.35.1670945991163; Tue, 13 Dec 2022 07:39:51 -0800 (PST) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id f13-20020a05600c4e8d00b003c70191f267sm14864594wmq.39.2022.12.13.07.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 07:39:50 -0800 (PST) From: Andrew Burgess To: Tom Tromey , Andrew Burgess via Gdb-patches Subject: Re: [PATCH 2/6] gdb/testsuite: fix gdb.trace/unavailable-dwarf-piece.exp with Clang In-Reply-To: <87v8mgfqvx.fsf@tromey.com> References: <87v8mgfqvx.fsf@tromey.com> Date: Tue, 13 Dec 2022 15:39:49 +0000 Message-ID: <87sfhj1fei.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> Currently, the unavailable-dwarf-piece.exp script names the assembler > Andrew> file using standard_output_file, in this commit I've switched to make > Andrew> use of standard_testfile, as that seems to be the more common way of > Andrew> doing this sort of thing. > > I think this caused the .S file to be created outside of the test's > directory. Using standard_output_file would fix this. I think it's > more normal to do this as well; searching for "set asm_file" yields a > lot of hits of the form: > > set asm_file [standard_output_file $srcfile2] > > So if this change isn't needed to make the test work with clang, I'd > suggest reverting this part. Sorry for this. I pushed the patch below to fix this issue. Thanks, Andrew --- commit dc3fb44540b586c02ec2f841e106a8d2cc2a422d Author: Andrew Burgess Date: Tue Dec 13 15:37:17 2022 +0000 gdb/testsuite: avoid creating temp file in gdb/testsuite/ directory After this commit: commit 33c1395cf5e9deec7733691ba32c450e5c27f757 Date: Fri Nov 11 15:26:46 2022 +0000 gdb/testsuite: fix gdb.trace/unavailable-dwarf-piece.exp with Clang The gdb.trace/unavailable-dwarf-piece.exp test script was creating a temporary file in the build/gdb/testsuite/ directory, instead of in the expected place in the outputs directory. Fix this by adding a call to standard_output_file. diff --git a/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp b/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp index 13c6f38737c..d73b9f1e33f 100644 --- a/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp +++ b/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp @@ -22,7 +22,7 @@ if {![dwarf2_support]} { standard_testfile .c -dbg.S -set asm_file $srcfile2 +set asm_file [standard_output_file $srcfile2] set opts {} if { [gdb_compile ${srcdir}/${subdir}/${srcfile} ${binfile}1.o \