From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 0F25F3858D20 for ; Thu, 10 Nov 2022 16:33:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0F25F3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2AAGJAGM031594; Thu, 10 Nov 2022 16:33:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2022-7-12; bh=in8zZw6C3nT6VaHHbuECsbVnyWXXKGr3nXwvmbTW9+8=; b=l/G9kuWLVnYK8Ev8CHOzdfa93BJr7SeQnL8QnjkO4oy2C2zGnQT67j8Kg/HHzg2MM8y7 u7sk5brKWbYbSP9Vu6kpeLAg0rtKlw2L2So67RDdj/r3ygIcQpvEqsd7wrsFqg8nAjxZ WtDbZHHdH+Qvr05C5EIVRhfjoM0mXRyzEvOnaxOcrM/4I9BvoWeqz0PpKhzj5ZtCohPa Ao1nxFDdCu+mKcdSwDETDrO41eMLe4wzB+l6ydZ4Zdi7KePB4W7+in1dsnnbvpHTUJg3 tcDAHKTAvf2RC81ZM8jS9rWZ1g1Dm1IQmlEsRhtx2vwGSwiln5bo1tERbeNd5rQ7A7HW 4Q== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ks4qdg1jj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Nov 2022 16:33:04 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2AAGCsmM009651; Thu, 10 Nov 2022 16:31:21 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2048.outbound.protection.outlook.com [104.47.73.48]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3kpcq55fbr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Nov 2022 16:31:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TlBsbPd3khUvq2yXk5sA+nOic2YvsReH3hU+QpsZBD2A/kZ4/19ttKtkkgKDxKDCBxVO3QreT/YY62gylZsSKwfVFCM5iA0g9ETRsgMNGiggDNkwXx84vO8IHRh1I2bRFt7IUl8ufogs1uVIqNwuXJdAPdwm5IZb1Mq7do4d4OLi5fZXpydW+ESzWIHlTeR7PStb/sEuhkceBY086Eau9FyRgx5DhxI8njFZFQRby41+m7/KtJIwD8uHmpNX8lwmjOAxIcpP5bpH8If6wR4I9na3jz8HHePrGLzWOsrbUeBbsPmzXiIToy5AVQ1YB6FDy97MzyyO2ZnxDGR8bxqYbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=in8zZw6C3nT6VaHHbuECsbVnyWXXKGr3nXwvmbTW9+8=; b=dgCqmIWa3LmhbdZngKq0FcjsHDve/snTJ7o38VoXjkk33qfA54dHetVvpg/qFYBU3Ht5QvLuNmpIUJh1Hw2KX2B+t4Exn24jKd5c4INCiK8naO6cqLwCZsT3423QgHhgXLVKeUn/hpp+9yjbfjooZTW1nD5wBemvZ5Oer5hDIMyCOsbjFu/tcVNH71rGDCt6p61molWFVh+tmVsc4rptfinnFb9NH0aLXNkECSkPoPX7HAqs3rhZxN7Sm0gXNZS4O6NCAnrZTxzH+KaHlZ92NxmmvnofeqnZMkIxOhE3UlLDuMerp47wQyrvT7JbE2BJG6EmWZwDabPxHLffvFzwGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=in8zZw6C3nT6VaHHbuECsbVnyWXXKGr3nXwvmbTW9+8=; b=WLE8Taj5XeMvmim5lCqXTLud1FblPyhQkuaaKiMQBXhkMF6zSxtbIod2zyTV/xbWW04HNz0aDv6d0VOOptOw5eStSJFrPAhXzuML6I5Yf5KTAuScQsuzW60VdJj3mgVOiCVOIpwWZpU8DXV/QSzkw1GU6vPLDthLzEUondr5W/Y= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by PH8PR10MB6339.namprd10.prod.outlook.com (2603:10b6:510:1ce::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Thu, 10 Nov 2022 16:31:19 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::1823:4d74:ed9b:7b5b]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::1823:4d74:ed9b:7b5b%4]) with mapi id 15.20.5813.012; Thu, 10 Nov 2022 16:31:19 +0000 From: "Jose E. Marchesi" To: nick.alcock@oracle.com Cc: Tom Tromey , "Jose E. Marchesi via Gdb-patches" , Simon Marchi , indu.bhagat@oracle.com, elena.zannoni@oracle.com Subject: Re: [PATCH] gdb: use libtool in GDB_AC_CHECK_BFD References: <20221107194634.1313150-1-jose.marchesi@oracle.com> <5e940b15-cd5c-83b2-0bdd-9afa27b5f197@simark.ca> <87bkpeuae6.fsf@oracle.com> <875yfmztd6.fsf@tromey.com> Date: Thu, 10 Nov 2022 17:35:09 +0100 In-Reply-To: <875yfmztd6.fsf@tromey.com> (Tom Tromey's message of "Thu, 10 Nov 2022 09:06:45 -0700") Message-ID: <87sfiqsr7m.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0221.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::10) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|PH8PR10MB6339:EE_ X-MS-Office365-Filtering-Correlation-Id: 7437ec7c-e181-41d9-1b8f-08dac338fedb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jpXY+dANP5gwPO2/mdVmliQDbAlOh6k8LlNIcC7yNmtJPuDTYRSq89PK55lk45anh0b4qXaCKzSqVJXyHvSrhrZSdgKYFQBlQ+BR5RJAzGZaiSyIpL5OORn3kF+c+wMk8Fo4IbBwA2H1JW0uW6b9rg0ztTtL/r24R43rRlndMDO1yNH/PKGqPlCx1X6Jzd0UDK5R1znYWKvsYmIiomUowh/55tLm+bNUOrioABi9NwdD+FbWi1AMOclzWmyVNlobAatSLwtGjFnHF+hrNY2PFFsKPzP35cHB6q3p5OkXsgoueiHii9PTVuSTswurDit+P0SDBf7oh/QzW14FadfI5D216As852LeHJDuqu5vyCTAFWAFobRC42FpnD0cfCrPVaFRboKcemStyScooSb0SJcdrquPQUbO73XMWkbF3HumwKRhFI6xJGReqlnX+4wU236Fw2tGD8GofFc0zXD9vNryYqHoxjzVuDiPjKnMaLve7gwXmyR+VHiemCGlZxZDPjSkdYQlTUNDOW5JiJutCQIaB0w6U0yEC1HdmQZMf+enmNiRKU5hhl/fzAFTccQib1b6HH4AjXBYjCvO1KuVyM0Qw77YJNsXu7jduB7Trht1bdDBfr0mEHVP/WLWY6QCYy8Wiq+NCSnzSo9i9NQO6E86KBeE09kzQEqmR4vi80J+DEAx9xhybBiDJFYoOdkX9OFIDTGf9QTv+oycJP3uIw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(136003)(39860400002)(346002)(376002)(451199015)(36756003)(6636002)(34206002)(66946007)(66556008)(54906003)(316002)(37006003)(66476007)(4326008)(8936002)(41300700001)(8676002)(5660300002)(86362001)(38100700002)(478600001)(6512007)(2616005)(6666004)(107886003)(6486002)(6506007)(26005)(186003)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m+C34MNzsaou4FzB42jiIBEEPkG6JlPtSu3SvaxKo815b4d/22YoEUYrgyNc?= =?us-ascii?Q?HhNvoCNOFwSpgs71yPlc7YrVuRi254szsRkMMiBmV8BzOWVdBHR+6dQL0Pl8?= =?us-ascii?Q?+gDpcABnNI6m0Y8vZhKQmBpfq2y49xRn0g/vWSDSQZtVWkUWIQeies7Z3t/t?= =?us-ascii?Q?03vDMAIaV9ukp13doJkp0hzHtb4eQ+chmAh7D4MMzjurOfCDwIp2MZhRzF77?= =?us-ascii?Q?nvLSMYCobYPV6v2C9F14WgYL3yqjrYhq4UkFMBIgC0LSatbSUE+3gRKCu//C?= =?us-ascii?Q?GvKoEimMWZyfV+iRSVynyepzbVRZaBNsSmRMPZo1qDea5kN5nb3RGAbcX9tH?= =?us-ascii?Q?cAn1Ga7zatc18rC457EVVYpkJfJv8gnK1z+039ChXVxPS9BK+Yj+Akc/3qRj?= =?us-ascii?Q?i9bmLSemQSM60Csb3CMPY79iaar4ShFmRKPz8l8ff9XzpLdnzuzburjPjzdw?= =?us-ascii?Q?HjoY8cgSq4ERPLZnQkI5c5xxX8oGR7LH52v7CXwUc+YwrC3BmLaX0bqugsww?= =?us-ascii?Q?wOQgcFsJsg125ZtkJziqNcnA9IQim8aMTljnNw9/l5I1GetDT+q87cGfJUpr?= =?us-ascii?Q?Is7Hy0ou8zoFxO02uWyfLoWt3ilb+xb+rHKHsIXXOqnA5nL4CBEiOmfzA2zE?= =?us-ascii?Q?JjQySl9/Okq7i+9mxXMD7NyYLaEUOV6fM9bCze4A6J4xj1RuktpEnBRYZj/i?= =?us-ascii?Q?eTwYcD4rCtLIbsrnIY0MbBe+ZUXA1cEs+wUml/fD66xfoiDOz8sZKeSCPWoX?= =?us-ascii?Q?JND7ivUas2f6fcUowcZL9i2G+TmZvnXO568EhWA7/kew/mFkw/2jhR1KxaSa?= =?us-ascii?Q?NbtkKAZBNRvqCQqL8X7lSfeGmUkDX5vd5axuGaMhw7LqtcyQxKT3nnZx+QvZ?= =?us-ascii?Q?cncOwUEWDWyuNkUiItVdISBQP/W/s2hqJ2WodfEdi2X57b47DwSe/q08kyxO?= =?us-ascii?Q?lv4y2ZsWm7e043iJiY3YiL+bbvZFxqVJzoX6cWXLkv2/6zV4nw6EdoIA1gDU?= =?us-ascii?Q?M2iDbmQQ5esBAY9VwjylBH3x1bPTe3tTxveEJdlb2Dz8skFgHGmeC6Fn0M2B?= =?us-ascii?Q?iyvCT+qYdytxYPPiljMDLS8g8fbQTRPyt2YyA9UvlVKKnEDRaS+XZlIPWtli?= =?us-ascii?Q?Yb+cPmA9DdeFyOvAH9JUgTGn8P/HmTRPPSnT/QEG4vQVzAMly6AMe8Hr4ePY?= =?us-ascii?Q?PF3beoVlsScSH8jBOgUyTxz+O+VcJJWagQAR0sKKmh6NbTsJycD2lJ/88KjX?= =?us-ascii?Q?GyO0sDd8Gl/s51Ernk9raJVQf3+BYAKh6wGB1JKxf7k/acfuf4R5y4Hito+x?= =?us-ascii?Q?MjgGsXQ5MphGVYm0KSVRtlU5X+qEiOZs20PI88u9CfDIuNWBm00dzDmq7uxu?= =?us-ascii?Q?7uiH547f8Gw8gAWAOJOw0tZvzZCuzL4Qymxu+h9jx3bDCKP8rc7e6qTKCgRS?= =?us-ascii?Q?8vVc52J/iwAGG+Vy6pl7TqQ/WCbNPw9f+9MgqJgGas5bNeP+i87JHHe2/Hor?= =?us-ascii?Q?Z8VJDcbPoKubHO3aJwnQZYxu/9DfliHhCYspRVoa2H1E89GVM92JvvLBUjPV?= =?us-ascii?Q?foeN54H9f3XDfTMOSKi6AZBftlr+ZWriKgFXK90Ci/f4iitYeK8oDch848X8?= =?us-ascii?Q?NA=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7437ec7c-e181-41d9-1b8f-08dac338fedb X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 16:31:19.0672 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9Gfut8VACFrWEaswm9Pa8CcX+BB81kAS44AOxJk5U4jvq1YzofzhbargfAvzeHtklTeXI6gQ40NZsWtJoJTP8JSSO5wG1pq+uBSHFq9kU+U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6339 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-10_10,2022-11-09_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0 malwarescore=0 mlxlogscore=932 mlxscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211100114 X-Proofpoint-ORIG-GUID: 6HsU7EDCpxncwzsNGZWAtsdJuBU9yE3k X-Proofpoint-GUID: 6HsU7EDCpxncwzsNGZWAtsdJuBU9yE3k X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>>> "Jose" == Jose E Marchesi via Gdb-patches writes: > > Jose> About gdb/Makefile.in... dunno, $(ZLIB) is included in CLIBS. This > Jose> makes me think GDB uses zlib directly? > > Jose> If it doesn't, I think you can remove: > > It doesn't directly: > > murgatroyd. git grep 'include.*zlib.h' | grep -v ChangeLog | grep -v '^zlib/' > bfd/compress.c:#include > binutils/readelf.c:#include > gas/compress-debug.c:#include > gold/compressed_output.cc:#include > gprofng/src/DbeJarFile.cc:#include "zlib.h" > include/ctf-api.h:#include > libbacktrace/ztest.c:#include > libctf/ctf-open.c:#include > libctf/ctf-serialize.c:#include > > Jose> 1) The calls to AM_ZLIB and AC_ZSTD from gdb/configure.ac. > Jose> 2) The definition of ZLIB and ZLIBINC from gdb/Makefile.in > Jose> 3) ../config/zlib.m4 from aclocal_m4_deps in gdb/Makefile.in > > ... however the use in ctf-api.h seems like it would prevent removing > some of the configury. gdb includes this header and so it needs the > correct -I options to find the in-tree zlib.h. > > I don't see why ctf-api.h needs this include, but I essentially don't > know anything about CTF. Nick, would it be possible to remove the include of zlib.h from ctf-api.h? Even if libctf uses zlib, it would be good to not expose the dependency in the API header...