From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B7EB33861872 for ; Thu, 20 Oct 2022 15:48:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B7EB33861872 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-55-1WXbpyLnPCiYFYt_h5xouw-1; Thu, 20 Oct 2022 11:48:03 -0400 X-MC-Unique: 1WXbpyLnPCiYFYt_h5xouw-1 Received: by mail-qt1-f197.google.com with SMTP id br5-20020a05622a1e0500b00394c40fee51so15450135qtb.17 for ; Thu, 20 Oct 2022 08:48:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YAdpPrNwCAQ4UImThoXePA2PI9nWNH6bDSpTurCY7LI=; b=YnNdjwRWMvxzHy72HdLCm8VFVR+YFgudUDD8ysT2pGPfiRlV5qauT3u6u6fkefg+Zy q/TclDzdRD2uN0ul/BfAlaXYxwZ6jyhmdU8JkpGBq/FwJmKeQ0lA/IxoWt0vE9wbpLHK DETjvpQsDHs3a2mxBigYa53vvBtygksNXjynzXCvU/Ywza5JGxX6sMCB4yDnooQKZx5Y gB/MoZiaF1FD6xejaYRcyrcBi7kx7DgOZ3DDnHlx9RpSf8xSXA0ySsPeZXf4uluIGic9 RMdKchHNzvjZ4xpGtSbdXCUlF/+APPmAPJQZQzyGB9ZM8jtNRdIfOCc6YgntYKNRhD7N PRwg== X-Gm-Message-State: ACrzQf1rZWq5kkgvBoBY4rcegHLWTdBZNyLiU6K7KEwUh4Uf7F7bVc8e wnoKcma0KSXUTIpIA+CmOyz3OVR0q02ry1ztkpaw8xX3T5HAuoV2DwHsFg+dUa8TEO03iKvHZJ6 mjAhXk2BlZmdE6qJwylyZ0A== X-Received: by 2002:a05:620a:448c:b0:6ee:d075:2078 with SMTP id x12-20020a05620a448c00b006eed0752078mr9664790qkp.273.1666280882692; Thu, 20 Oct 2022 08:48:02 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5XLt0NkfbaqdqxvZHuohmwYsIaG26ektsyIJfgAOvJ8Ym+BR4QqCRRo6xmo921dVxFfmsTMg== X-Received: by 2002:a05:620a:448c:b0:6ee:d075:2078 with SMTP id x12-20020a05620a448c00b006eed0752078mr9664770qkp.273.1666280882448; Thu, 20 Oct 2022 08:48:02 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id c8-20020a05620a268800b006cfaee39ccesm7513118qkp.114.2022.10.20.08.48.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 08:48:02 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCHv2 4/4] gdb: some int to bool conversion in breakpoint.c In-Reply-To: References: <62e73978fa2b623f42e567d34429104fe70304c5.1666184729.git.aburgess@redhat.com> Date: Thu, 20 Oct 2022 16:48:00 +0100 Message-ID: <87sfjia43z.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2022 15:48:07 -0000 Simon Marchi writes: > On 10/19/22 09:07, Andrew Burgess via Gdb-patches wrote: >> Some int to bool conversion in breakpoint.c. I've only updated the >> function signatures of static functions, but I've updated some >> function local variables throughout the file. >> >> The most interesting change is in unduplicated_should_be_inserted, >> where I've made use of make_scoped_restore to temporarily change the >> bl->duplicate flag. > > This isn't part of this patch. Ooops, I decided to split this into a separate patch and forgot to update the commit message. I fixed this before committing. > > Some nits below, but otherwise, the series LGTM: > > Approved-By: Simon Marchi > >> @@ -1922,7 +1922,7 @@ add_dummy_location (struct breakpoint *b, >> watchpoint removal from inferior. */ >> >> static void >> -update_watchpoint (struct watchpoint *b, int reparse) >> +update_watchpoint (struct watchpoint *b, bool reparse) > > Update the REPARSE doc, non-zero -> true. > >> @@ -4216,7 +4216,7 @@ moribund_breakpoint_here_p (const address_space *aspace, CORE_ADDR pc) >> /* Returns non-zero iff BL is inserted at PC, in address space >> ASPACE. */ >> >> -static int >> +static bool >> bp_location_inserted_here_p (const struct bp_location *bl, > > non-zero -> true in the doc Thanks, I made the fixes you suggested, and pushed this series. Andrew