From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id D24363858C52 for ; Fri, 23 Sep 2022 13:45:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D24363858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 951D610064DBE for ; Fri, 23 Sep 2022 13:45:12 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id bizPoHPVhlpGebizQo4j4U; Fri, 23 Sep 2022 13:45:12 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=I/ag+Psg c=1 sm=1 tr=0 ts=632db868 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=xOM3xZuef0cA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=_uSOa7VeoJI6HUHdVyEA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=u/WVEZFznBpCPO7z650EDMdjZzZ5zaItfsQe5KFwTbg=; b=UQUO7QXVUxKkmFT4e6YexHavjQ AAPeSNM1ZiiptnGpBLT/nMIrNEyWMseM/gj26ZbvSkvQujQAliDkG4qf7e0C5an1RaDkZdEazA1zx ZVEI4b10Klye7gVW6zplSu0QV; Received: from 71-211-160-49.hlrn.qwest.net ([71.211.160.49]:56562 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1obizP-001X9e-8v; Fri, 23 Sep 2022 07:45:11 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH][gdb/symtab] Redo "Fix assert in set_length" References: <20220922130015.GA25067@delia.home> X-Attribution: Tom Date: Fri, 23 Sep 2022 07:45:06 -0600 In-Reply-To: <20220922130015.GA25067@delia.home> (Tom de Vries via Gdb-patches's message of "Thu, 22 Sep 2022 15:00:22 +0200") Message-ID: <87sfki19y5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.160.49 X-Source-L: No X-Exim-ID: 1obizP-001X9e-8v X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-160-49.hlrn.qwest.net (murgatroyd) [71.211.160.49]:56562 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Sep 2022 13:45:26 -0000 >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> The fix is to not use the CU table in a .debug_names section to construct Tom> all_comp_units, but instead use create_all_comp_units, and then verify the CU Tom> table from .debug_names. This also fixes PR25969, so remove the KFAIL. Note that create_all_comp_units was apparently renamed, so this text should be changed. Part of the point of the indices is to avoid reading .debug_info until needed -- so scanning it should not be necessary. I assume this change would cause a performance drop. Checking whether performance suffers would be interesting. If it doesn't, I'd be more inclined to do this. Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29572 In this one I see the comment: This happens fine for CUs, but in this case it's a PU. Does .debug_names even work with partial units? I thought there was some hole in this area. Maybe it is just "dwz -m" that can't work with .debug_names? I don't recall any more. Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=25969 I'm not sure I understand this one, but it says: AFAIU, to fix this, we'll have to do a top-level scan of the CUs, and build partial symbols for CUs are not contained in any index. I think if the index is incomplete, and gdb can detect that, then it should simply be discarded and a full scan done. Trying to use both .debug_names and a partial cooked index is going to make everything more complicated for, IMO, very little gain. Tom