From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 29FF63858282 for ; Wed, 21 Sep 2022 14:52:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 29FF63858282 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id F2E7010097F65 for ; Wed, 21 Sep 2022 14:52:31 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id b15Toot87lpGeb15TocQkX; Wed, 21 Sep 2022 14:52:31 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=UZmU9IeN c=1 sm=1 tr=0 ts=632b252f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=xOM3xZuef0cA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=KSvQeL0vgKbxUyfw-_kA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wdgdbEyqew3ayJNHAKebNXcujq51ERzPJsLA/RsK8h0=; b=VnKokCKKZYyHJLWVmCb+q/yGg8 6aS+ameDSb+kpqIpfw5MjPsawy14JlO5i3Zgek3ZIrO+yrq8idmrF239CEdNiBUJ+bbB6BUvc+U2K IVZM5kkbKfLP2kp+O/yeGo6yi; Received: from 71-211-160-49.hlrn.qwest.net ([71.211.160.49]:56522 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ob15S-004GnW-Pb; Wed, 21 Sep 2022 08:52:30 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH 1/4] gdb: add type::target_type / type::set_target_type References: <20220916150836.527213-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Wed, 21 Sep 2022 08:52:25 -0600 In-Reply-To: <20220916150836.527213-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Fri, 16 Sep 2022 11:08:33 -0400") Message-ID: <87sfkk4w5y.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.160.49 X-Source-L: No X-Exim-ID: 1ob15S-004GnW-Pb X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-160-49.hlrn.qwest.net (murgatroyd) [71.211.160.49]:56522 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2022 14:52:48 -0000 Simon> Add the `target_type` and `set_target_type` methods on `struct type`, in order Simon> to remove the `TYPE_TARGET_TYPE` macro. In this patch, the macro is changed to Simon> use the getter, so all the call sites of the macro that are used as a setter Simon> are changed to use the setter method directly. The next patch will remove the Simon> macro completely. This looks good to me. Thanks for doing this. Tom