From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8548E3858D38 for ; Tue, 20 Sep 2022 13:59:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8548E3858D38 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-258-9S3pyELmMcS1ScV1i1g6OA-1; Tue, 20 Sep 2022 09:59:23 -0400 X-MC-Unique: 9S3pyELmMcS1ScV1i1g6OA-1 Received: by mail-wm1-f72.google.com with SMTP id p24-20020a05600c1d9800b003b4b226903dso6347610wms.4 for ; Tue, 20 Sep 2022 06:59:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=F4T3WwPhWzqchAEtDUThk10mWt1k7Ho215XJDmLz8SA=; b=Ja7m13I8AvVblfW0RchQvhPiauh9YmL75sRjmZCMABxFg2n2A+R3V1l9tW1uGsd2sO uosyuefymZMeLsw8c2I5LZld5awouQ0fgkrWCXOSBbJBZmDjVgP0x2VHx7nSn2Plnjfy Y67Hzd1wup7wd+AWPr3cf+yAsLFVIBsUZw0GyRrPhJCAITZkIWVu5SOnKDCTGafr2y7L gEMb2yJyXAmzOU038O1bvEuDPZDkNtQvzRLJ3V19qFskLoJKspIo7D8qkMD0NMLgAGPM KFluGu2+JHfSU4nhtaUVFkxy9up/8mCW3nUtyfhDaIM+8DJLpsXL1yusjHy6JAhQqwJa iZ5A== X-Gm-Message-State: ACrzQf2067LPhtZ3aVTtxNB50t0dHVmKceI/UDkwWkJRiRpNVRqtKLLQ VnewB7mauGywx8J32VO5ztb/B7yDsL0X65WjqEp9gWD5V6D2zM6NtslA25e84JSipRRiWYjDXdK lrc29QrrVz8Z4Y7YcRKx/OQ== X-Received: by 2002:a5d:46ce:0:b0:22a:f992:42b4 with SMTP id g14-20020a5d46ce000000b0022af99242b4mr7585818wrs.108.1663682361634; Tue, 20 Sep 2022 06:59:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7tCr+gfEDfcqbQ79HUL1JovYJhBChDpcisJKqv5vSnG0A/JEqlvHdomabjpHcpK66Gck9Aqg== X-Received: by 2002:a5d:46ce:0:b0:22a:f992:42b4 with SMTP id g14-20020a5d46ce000000b0022af99242b4mr7585806wrs.108.1663682361418; Tue, 20 Sep 2022 06:59:21 -0700 (PDT) Received: from localhost (52.72.115.87.dyn.plus.net. [87.115.72.52]) by smtp.gmail.com with ESMTPSA id f18-20020a7bcc12000000b003a3442f1229sm89987wmh.29.2022.09.20.06.59.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 06:59:21 -0700 (PDT) From: Andrew Burgess To: Aaron Merey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: add a debuginfod-support.exp helper library In-Reply-To: References: <20220907135136.602656-1-aburgess@redhat.com> Date: Tue, 20 Sep 2022 14:59:20 +0100 Message-ID: <87sfkmdu4n.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2022 13:59:25 -0000 Aaron Merey writes: > Hi Andrew, > > On Wed, Sep 7, 2022 at 9:51 AM Andrew Burgess via Gdb-patches > wrote: >> >> We currently have a single test for GDB's debuginfod support, this is >> gdb.debuginfod/fetch_src_and_symbols.exp, this script does all the >> setup, starts debuginfod, and then does the testing. >> >> This commit tries to split the existing script in two, there is a new >> library lib/debuginfod-support.exp, which contains a helper functions >> related to running debuginfod tests. All the code in the new library >> is basically copied from the existing test case (which is why I >> retained the copyright date range on the new library), with some minor >> adjustments to try and make the code a little more generic. >> >> One change I made, for example, is the library offers functions to >> shut down debuginfod, previously we just relied on expect shutting >> down debuginfod when dejagnu completed. >> >> The existing test script is updated to make use of the new library >> code, and this test is still passing for me. The only change in the >> test results is a single test where I changed the name to remove the >> port number from the test name - the port number can change from run >> to run, so could make it hard to compare test results. >> >> I have also done a little light house keeping on the original test >> script, updating and adding new comments, and making use of >> proc_with_prefix in a couple of places. > > Thanks for cleaning this up. The debuginfod tests all pass for me with > this patch applied on F36. The server process correctly terminates > once the tests are finished, even if I ctrl-c part way through. Thanks for checking this. I've gone ahead and pushed this patch. Thanks, Andrew