From: Tom Tromey <tom@tromey.com>
To: Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org>
Cc: Lancelot SIX <lancelot.six@amd.com>,
lsix@lancelotsix.com, Pedro Alves <pedro@palves.net>
Subject: Re: [PATCH v3 2/3] gdb/varobj: Fix use after free in varobj
Date: Fri, 15 Jul 2022 11:58:09 -0600 [thread overview]
Message-ID: <87sfn2ntqm.fsf@tromey.com> (raw)
In-Reply-To: <20220708103719.2825286-3-lancelot.six@amd.com> (Lancelot SIX via Gdb-patches's message of "Fri, 8 Jul 2022 11:37:18 +0100")
>>>>> "Lancelot" == Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org> writes:
Lancelot> This patch also makes sure to keep a reference to the expression's
Lancelot> gdbarch and language_defn members when the varobj->root->exp is
Lancelot> initialized. Those structures outlive the objfile, so this is safe.
[...]
Thanks, this looks good to me.
Tom
next prev parent reply other threads:[~2022-07-15 17:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 10:37 [PATCH v3 0/3] Fix some use-after-free errors in varobj code Lancelot SIX
2022-07-08 10:37 ` [PATCH v3 1/3] MI: mi_runto -pending Lancelot SIX
2022-07-15 17:34 ` Tom Tromey
2022-07-15 17:38 ` Tom Tromey
2022-07-08 10:37 ` [PATCH v3 2/3] gdb/varobj: Fix use after free in varobj Lancelot SIX
2022-07-15 17:58 ` Tom Tromey [this message]
2022-07-08 10:37 ` [PATCH v3 3/3] gdb/varobj: Fix varobj_invalidate_iter Lancelot SIX
2022-07-15 18:16 ` Tom Tromey
2022-07-26 8:00 ` Six, Lancelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfn2ntqm.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
--cc=lsix@lancelotsix.com \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).