From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by sourceware.org (Postfix) with ESMTPS id 3E70038303C5 for ; Mon, 6 Jun 2022 18:44:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3E70038303C5 Received: by mail-io1-xd35.google.com with SMTP id a10so13132086ioe.9 for ; Mon, 06 Jun 2022 11:44:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=19HPJvYdZ/F8Bg5Si+6LwMkOOt79/Ly4E3io2tyjPHs=; b=mW0c3u2aDdvJdh7qm11+pjZVKzV2LCyGN+pTFMV/iIRnS3tipU8JaKd5D4sBf6iMfV 0SJI83pxsiTbOraUMdwdnfa0uAiUmMpMoqEgENRYLjlISDSQodw8Vgnh0CuFgmbB737h h0q2fDyuMK2GdaAA+IcWIcPlDRbmW+oZb2pGqU+ImVqzEkZr+Reg/OKmWJ0mOdiyBNnw tuz1bJhNbQOTXbcEsSNNMp+uR3pyx2h7rXdg1w09TYtvHcOhg30mM4iorhQXQMMSgnMJ h0ytDC8OYTLWsjJakonJlK3k5s7WxM4Kj7yRWRRr2D0+x1dV9ht6YDOGH9hBr4A6vXOZ xWvQ== X-Gm-Message-State: AOAM530RZFt7kZP1yeHdP58saFE/zWrVYmB7nfv1kvjK99nHXeR8NvOf k/JfMWphvaA41Akt/ffj0+FK3MAx6HB4/A== X-Google-Smtp-Source: ABdhPJyG+aLMqiZlom8l3hPI0xVG1TSvj5pv3xb9hFpvbo1nUroAkO13/ZF2teek9hNRfQICMaC/sA== X-Received: by 2002:a05:6602:2c09:b0:669:71e5:5e5d with SMTP id w9-20020a0566022c0900b0066971e55e5dmr582894iov.171.1654541045533; Mon, 06 Jun 2022 11:44:05 -0700 (PDT) Received: from murgatroyd (71-211-171-143.hlrn.qwest.net. [71.211.171.143]) by smtp.gmail.com with ESMTPSA id cq4-20020a056638478400b003316f4b9b26sm4883235jab.131.2022.06.06.11.44.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 11:44:05 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Simplify varobj "change" logic References: <20220526164906.1096660-1-tromey@adacore.com> X-Attribution: Tom Date: Mon, 06 Jun 2022 12:44:04 -0600 In-Reply-To: <20220526164906.1096660-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Thu, 26 May 2022 10:49:06 -0600") Message-ID: <87sfohzl6z.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2022 18:44:07 -0000 >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> varobj used to store 'print_value' as a C string, where NULL was a Tom> valid value, and so it had logic to handle this situation. However, Tom> at some point this was changed to be a std::string, and so the code Tom> can be simplified in this spot. I'm going to check this in shortly. Tom