From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 084473858C2C for ; Tue, 17 May 2022 22:48:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 084473858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 75C461004C135 for ; Tue, 17 May 2022 22:48:29 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id r5zQnpDQOkku4r5zRn3Yxi; Tue, 17 May 2022 22:48:29 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=C5AsdSD+ c=1 sm=1 tr=0 ts=6284263d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=oZkIemNP1mAA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=T_Alst9gAAAA:8 a=RsLVZtoQwIhOPm8uLIIA:9 a=DvZ5ixILWSEuw56YIEpp:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=b3Sq7r3PNYVqth0AqoFN7Ma8omW5mWVXSeciavsMTaA=; b=ddiLb7GEYRZcsq9VTzAouNzRDX 6uiTvZXqJbNTCLdttK5iafvoC846OE+RQoYJic1A0N+VQTLXR1aH1AWqaC4iNJrGd12AlXMthrTsN S5Q9KAU8DJwCH13ArW0zD9d6H; Received: from [161.98.8.3] (port=52330 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nr5zQ-003VMh-JP; Tue, 17 May 2022 16:48:28 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 5/5] Make gdb_test's question non-optional if specified References: <20220330192929.3161015-1-pedro@palves.net> <20220330192929.3161015-6-pedro@palves.net> <87o7zxeaa6.fsf@tromey.com> X-Attribution: Tom Date: Tue, 17 May 2022 16:48:27 -0600 In-Reply-To: (Pedro Alves's message of "Tue, 17 May 2022 12:25:16 +0100") Message-ID: <87sfp7kc78.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 161.98.8.3 X-Source-L: No X-Exim-ID: 1nr5zQ-003VMh-JP X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (prentzel) [161.98.8.3]:52330 X-Source-Auth: tom+tromey.com X-Email-Count: 18 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 22:48:31 -0000 >>>>> "Pedro" == Pedro Alves writes: >> proc gdb_test {command pattern {message ""} {question ""} {response ""}} >> >> ... and then default 'message' when appropriate. Pedro> (Note pattern is optional too.) Oh yeah, I forgot about that. Pedro> In the patch below I've added support for -prompt and -lbl, and Pedro> one example using gdb_test -prompt, to show better what I mean. Seems pretty reasonable. Pedro> + set command [lindex $args 0] Pedro> + set pattern [lindex $args 1] Pedro> + set message [lindex $args 2] Pedro> + set question [lindex $args 3] Pedro> + set response [lindex $args 4] You can also write: lassign $args command pattern message question response Tom