From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id A82F73858D28 for ; Mon, 18 Apr 2022 15:03:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A82F73858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id DFBB710044F6B for ; Mon, 18 Apr 2022 15:03:29 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id gSuXnKFi153CXgSuXn21pS; Mon, 18 Apr 2022 15:03:29 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=OPfiYQWB c=1 sm=1 tr=0 ts=625d7dc1 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=z0gMJWrwH1QA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=b8LmKYDAvhgPajJQAxYA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jYBX9SWe0w2Nx5h6/Hz1dDMSJWmcJ2g+8bjuwMUTYaU=; b=SjUVrHFPt3H74gKX7nL0DgL3FR L53B6sfF6k9loUB0iHTchQOxFlngIiaNe7i7OiEtdIsGF0UU8HUW9pYSZcP14zO5rilQK/1FQZKwg yLogcD9ekKizuYzwhflyp7KGx; Received: from 71-211-154-204.hlrn.qwest.net ([71.211.154.204]:55604 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ngSuW-000RqY-R0; Mon, 18 Apr 2022 09:03:28 -0600 From: Tom Tromey To: "Natarajan, Kavitha via Gdb-patches" Cc: Tom Tromey , "Natarajan, Kavitha" , "George, Jini Susan" , "Parasuraman, Hariharan" Subject: Re: [PATCH] Debug support for global alias variable References: <66ca57f9-c3b8-4aeb-f07c-c3c254dfdea6@redhat.com> <87ilra1gcx.fsf@tromey.com> X-Attribution: Tom Date: Mon, 18 Apr 2022 09:03:28 -0600 In-Reply-To: (Kavitha via Gdb-patches Natarajan's message of "Mon, 18 Apr 2022 11:04:43 +0000") Message-ID: <87sfqawi0v.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.154.204 X-Source-L: No X-Exim-ID: 1ngSuW-000RqY-R0 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-154-204.hlrn.qwest.net (murgatroyd) [71.211.154.204]:55604 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2022 15:03:32 -0000 >>>>> Natarajan, Kavitha via Gdb-patches writes: > There doesn't seem to be any impact on other languages as the new symbol is > created only for TYPE_CODE_NAMESPACE in read_namespace_alias function. > However, it could regress with my change. So I have moved this check specific > to my change so that this change is specific to C/C++ global alias variables. Is there a reason not to handle other languages here? > + if (((cu->per_cu->lang == language_c) > + || (cu->per_cu->lang == language_cplus)) > + && (d->tag == DW_TAG_variable)) This is over-parenthesized. However, I still think that the language checks should probably be removed. I'd like to get the Ada compiler using imports like this to represent renamings, though I haven't tried it yet. thanks, Tom