From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AAA933858D37 for ; Tue, 5 Apr 2022 08:24:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AAA933858D37 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-240-4kvt90_ZNO6S_PRnLtsugA-1; Tue, 05 Apr 2022 04:24:56 -0400 X-MC-Unique: 4kvt90_ZNO6S_PRnLtsugA-1 Received: by mail-wm1-f72.google.com with SMTP id 189-20020a1c02c6000000b0038e6c4c6472so989020wmc.1 for ; Tue, 05 Apr 2022 01:24:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=RYiWJ0ZgdAyqQaj1ttmFowW8RASiLox8Ofk2ZFF5XZo=; b=sQodvS/X5LyR+eAcgXZQTH5uDKNf2H4B/22AP8X/cumkTvcydEajN1j6J+Vi8REAes +Xlk/k4GW2cAwRjdlGYxFB5bsN63vE3vSBHlQPkj7SExYyOO8t5qDFqGfZhxBq34UvcM bBABVUoBuq7WUQaqxK/4OhZlPZW0hzKA1zH8q4xhV9zo7oYAzyYWA6OsgKH0bxoWzweY tKEa5GeYb+pDoQ1TWhvKRbDMrnokcPHnbxxiux5MjMsDKPG+2QSGpnH+T2oKytPsltaw Et1PMLIt4QHXTM1Gu+OnsMBWadl03xAh53JE3vqjb56UEth/+SYW3mlfSwYxYcGKyPc3 b0Og== X-Gm-Message-State: AOAM532SyaD33M7CMdy8m2ZLUGvVWgS0PWsnHwrsImrBZ+Hm6sod8/Xn v1EzTwvoILq6FJTx6ICJGt/ime2LlgQSDzpZA8Px3gXh74GPBz4ILNKrmxyNBb9faFDkDgsgWVW +lr9RimEJncxveN8pxdI9PQ== X-Received: by 2002:a05:6000:144d:b0:205:8905:4cc1 with SMTP id v13-20020a056000144d00b0020589054cc1mr1751427wrx.508.1649147095393; Tue, 05 Apr 2022 01:24:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkdwHGDjv/jFjW/4vsxo245nItdU9R9wie5UxrTEiGIUGcJjUM1tTxPZNpo6th/YZ59capFA== X-Received: by 2002:a05:6000:144d:b0:205:8905:4cc1 with SMTP id v13-20020a056000144d00b0020589054cc1mr1751413wrx.508.1649147095149; Tue, 05 Apr 2022 01:24:55 -0700 (PDT) Received: from localhost (host86-169-131-113.range86-169.btcentralplus.com. [86.169.131.113]) by smtp.gmail.com with ESMTPSA id h133-20020a1c218b000000b0038e7c143e78sm1431614wmh.45.2022.04.05.01.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 01:24:54 -0700 (PDT) From: Andrew Burgess To: Lancelot SIX Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 03/16] gdb: make gdbarch_register_reggroup_p take a const reggroup * In-Reply-To: <20220404223527.l7k3ekywgszcyw4d@ubuntu> References: <20220404223527.l7k3ekywgszcyw4d@ubuntu> Date: Tue, 05 Apr 2022 09:24:53 +0100 Message-ID: <87sfqs6ip6.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2022 08:25:01 -0000 Lancelot SIX via Gdb-patches writes: > Hi, > >> diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c >> index 4d0f3492410..c857f5ca7d1 100644 >> --- a/gdb/arm-tdep.c >> +++ b/gdb/arm-tdep.c >> @@ -8986,7 +8986,7 @@ arm_elf_osabi_sniffer (bfd *abfd) >> >> static int >> arm_register_reggroup_p (struct gdbarch *gdbarch, int regnum, >> - struct reggroup *group) >> + const struct reggroup *group) > ^ > Small nit, looks like you dropped a space here. The original line had an extra space, the 'c' of const was aligned to the 't' of struct above it, so I have removed the extra space here, but that was intentional. Always happy to check these things though. Thanks, Andrew