From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BF8553857829 for ; Mon, 14 Mar 2022 14:10:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BF8553857829 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-201-rMK6gr5LPAOz2z1N-NtAgA-1; Mon, 14 Mar 2022 10:10:24 -0400 X-MC-Unique: rMK6gr5LPAOz2z1N-NtAgA-1 Received: by mail-wm1-f69.google.com with SMTP id o33-20020a05600c512100b0038a1d06e525so51387wms.2 for ; Mon, 14 Mar 2022 07:10:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=zNHlROJxWrVJGGySY3wt+0ujhZvfqqbuglMwH1ZJsTM=; b=OB5O4JMO5R8x9H7C095iJ1dj6FM0DQwR6TX79WbvQXwqmNzvenwo6RNk/McDgw6FZ4 D7RlB6jfp5DugnEJVwbmx/sk2T33duA3KKlgyNdTS4yoZQUmxas3TThgb1R2WgDOnONz gdhgOTK3FeP/CAIMZmdXONyMlrq2UUH1qql22cUbgvxsFKioqmMMPlKKPEP2u8sHcYff XsAVWYR3JdusolvJE92nRhKrCo+NUXhKSwyS0Q7UP0wvAgirGKa4Md+I1l2/XpAlKXDd 6WngGhoEG/iGRerqXxxaSvrYEc81D5a4kINAY9dMIdFEDM2l8wZ6u2SoBGBfp40T3dn9 Dj5A== X-Gm-Message-State: AOAM532Bcxa+oXLxR/IeqqseiEb2hh9Fm/7E8BT26e8E7rRO3Tr7SZwE RVUg0pX92cEIDB6wrOnhNDxw+cujXYbpKLoRU5t5p0Hi/s75X+XtVpHEzNJi+HIIwHzFY3AztWz nDpGjsC2L9iyhVxOR/9Y8uw== X-Received: by 2002:a05:600c:643:b0:389:9596:4d27 with SMTP id p3-20020a05600c064300b0038995964d27mr26267956wmm.194.1647267023119; Mon, 14 Mar 2022 07:10:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzm2A5hyMgP+c8Hj2q1E3y1O/uhFRjBMC+KWitpwgSdxM0N1BfbFWOxDwDf/TOk1VhwVfdJBA== X-Received: by 2002:a05:600c:643:b0:389:9596:4d27 with SMTP id p3-20020a05600c064300b0038995964d27mr26267943wmm.194.1647267022931; Mon, 14 Mar 2022 07:10:22 -0700 (PDT) Received: from localhost (host109-154-72-186.range109-154.btcentralplus.com. [109.154.72.186]) by smtp.gmail.com with ESMTPSA id l25-20020a1c7919000000b0038999b380e9sm14869938wme.38.2022.03.14.07.10.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Mar 2022 07:10:22 -0700 (PDT) From: Andrew Burgess To: Tom Tromey , Andrew Burgess via Gdb-patches Subject: Re: [PATCH 2/2] gdb/gdbarch: compare some fields against 0 verify_gdbarch In-Reply-To: <87sfrpoht5.fsf@tromey.com> References: <390f01c81a056b73b104ff580fcbea5c633acb9a.1646918997.git.aburgess@redhat.com> <87sfrpoht5.fsf@tromey.com> Date: Mon, 14 Mar 2022 14:10:21 +0000 Message-ID: <87sfrkvd4i.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2022 14:10:27 -0000 Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> The comment at the top of gdbarch-components.py tries to explain how > Andrew> the validation is done. I didn't understand this comment completely, > Andrew> but, I think this final sentence: > > I wrote it and now I don't really understand it either. > I guess I wasn't being as clear as I thought I was. > > Andrew> 1. Handle the case where the 'invalid' field of a property is set to > Andrew> True, this should perform a check for the field of gdbarch still > Andrew> being set to 0, and > > Andrew> 2. If the if/else series that generates verify_gdbarch doesn't handle > Andrew> a property then we should raise an exception. This means that if a > Andrew> property is added which isn't handled, we should no longer silently > Andrew> ignore it. > > Looks good. Thanks, I pushed both these patches. Andrew