From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.119]) by sourceware.org (Postfix) with ESMTPS id 5C9113857808 for ; Thu, 10 Jun 2021 18:48:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C9113857808 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 0BFDD20ED2E for ; Thu, 10 Jun 2021 13:48:41 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id rPjNl9WXuMGeErPjNlxWFD; Thu, 10 Jun 2021 13:48:41 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sWXsS2/tToRayKwXNlpoM8EJioSmzbKrVH3Dvw3Pumo=; b=YpkU6PRmm/Xz4yPrLe0HB0dn2a G61Hc7XYQalTMJyQke9IGQbJBsk6v68CfeMsvdazP/xij9C/26uk6SrdNB6j3XtryzIA5XqZVgQt4 3s54nfiHrvdyJvmBt6YL2kHwr; Received: from 97-122-81-113.hlrn.qwest.net ([97.122.81.113]:41242 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lrPjM-0008Y0-PS; Thu, 10 Jun 2021 12:48:40 -0600 From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , Hannes Domani , Hannes Domani via Gdb-patches Subject: Re: [PATCHv2] Restore gdb.SYMBOL_STRUCT_DOMAIN constant References: <20210526170536.657-1-ssbssa.ref@yahoo.de> <20210526170536.657-1-ssbssa@yahoo.de> <87k0ncp0v4.fsf@tromey.com> <2129329660.4623528.1622725230456@mail.yahoo.com> <6f5127bc-9967-4b17-b851-2f14276e3b5e@suse.de> <259660019.5490657.1622896987146@mail.yahoo.com> <8735tw1kjv.fsf@tromey.com> <5a314e1b-4cc7-af38-81e9-df4e37e793a8@suse.de> X-Attribution: Tom Date: Thu, 10 Jun 2021 12:48:40 -0600 In-Reply-To: <5a314e1b-4cc7-af38-81e9-df4e37e793a8@suse.de> (Tom de Vries's message of "Sun, 6 Jun 2021 00:36:32 +0200") Message-ID: <87sg1ph7xz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.81.113 X-Source-L: No X-Exim-ID: 1lrPjM-0008Y0-PS X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-81-113.hlrn.qwest.net (murgatroyd) [97.122.81.113]:41242 X-Source-Auth: tom+tromey.com X-Email-Count: 24 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2021 18:48:42 -0000 >>>>> "Tom" == Tom de Vries writes: Tom> Maybe easy enough to warn about in gdb_test_multiple: Tom> ... Tom> if { [regexp -line {python print +[^(]} $command] } { Tom> warning [concat \ Tom> "Missing parentheses in python print command," \ Tom> " will fail with python3"] Tom> } Tom> ... Tom> ? Tom> Or, even correct automatically: Tom> ... Tom> if { [regexp -line {python print +[^(]} $command] } { Tom> set command [regsub {python print (.*)} $command \ Tom> {python print (\1)}] Tom> } Tom> ... Tom> ? I find auto-fixing pretty funny somehow, but I feel like it might be confusing or even bite us someday. Another way out would be a new proc to wrap "python print" so that it's just not possible to mess up. Tom