From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] Don't run personality syscall at configure time; don't check it at all
Date: Fri, 07 May 2021 14:37:05 -0600 [thread overview]
Message-ID: <87sg2ymgb2.fsf@tromey.com> (raw)
In-Reply-To: <0cdaca38-aef0-ddc5-dd48-61ddf594119a@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Fri, 7 May 2021 10:32:53 -0400")
Simon> This happens since commit adeab0c5b33f ("config/debuginfod: do not
Simon> include pkg.m4 directly"). The commit message hints that we should run
Simon> autoconf with -I ../config, and indeed it works:
Yeah, aclocal needs to pick up the -I options. If we used automake, it
would pick them out of Makefile.am, but since we don't I guess it
doesn't know how.
Simon> However, I never needed to use -I ../config before, so I don't know why
Simon> it would be needed now (and we use plenty of other macros from config/).
Simon> Do we need to list ../config/pkg.m4 in our acinclude.m4?
I think we could do that.
Simon> Or, isn't
Simon> there a way in our configure.ac to say that we always want to include
Simon> ../config?
This area remains under-developed AFAIK.
Tom
next prev parent reply other threads:[~2021-05-07 20:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 22:47 Pedro Alves
2021-05-07 14:32 ` Simon Marchi
2021-05-07 20:37 ` Tom Tromey [this message]
2021-05-09 1:12 ` Simon Marchi
2021-05-08 12:47 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg2ymgb2.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).