From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>,
gdb-patches@sourceware.org,
Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [RFC][gdb/symtab] Add DW_IDX_GNU_main_subprogram
Date: Tue, 02 Mar 2021 08:01:35 -0700 [thread overview]
Message-ID: <87sg5dd2gg.fsf@tromey.com> (raw)
In-Reply-To: <b1e1f07b-97c8-7eec-cd23-38768043d2b4@suse.de> (Tom de Vries's message of "Tue, 2 Mar 2021 07:49:53 +0100")
Tom> One might say though that this is an actual gdb bug. The dwarf standard
Tom> says that the "string _begins_ with a 4-character vendor ID". So the
Tom> code should not check for augmentation_string_size == sizeof
Tom> (dwarf5_augmentation).
Yes. Also "GDB" isn't 4 characters. However, GDB also puts the wrong
names into .debug_names, so the problems go much further than that.
Tom> Anyway, to support any older reader that does the right thing, we'd need
Tom> to use "GDB\0name_of_main" or some such.
Tom> For future extensibility, we might consider encoding the type of data
Tom> using a char, like so "GDB\0M:name_of_main".
Makes sense to me!
Tom
prev parent reply other threads:[~2021-03-02 15:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 15:47 [PATCH][gdb/testsuite] Add KFAILs for PR symtab/24549 Tom de Vries
2021-02-05 15:25 ` Tom Tromey
2021-02-05 17:28 ` Tom de Vries
2021-02-08 11:46 ` [RFC][gdb/symtab] Add DW_IDX_GNU_main_subprogram Tom de Vries
2021-02-24 20:46 ` Tom Tromey
2021-02-24 20:51 ` Tom Tromey
2021-03-02 1:44 ` Tom Tromey
2021-03-02 6:49 ` Tom de Vries
2021-03-02 15:01 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg5dd2gg.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).