From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.45.147]) by sourceware.org (Postfix) with ESMTPS id 47CE8385BF92 for ; Wed, 1 Apr 2020 20:22:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 47CE8385BF92 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 3936D400EA7FB for ; Wed, 1 Apr 2020 15:20:51 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Jjr1jgS301s2xJjr1jMYLt; Wed, 01 Apr 2020 15:20:51 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2LIv9bEDrlYmfi5UAL2asphLM0jBTH67l4j5Urj7SkE=; b=EC0z2eptKG1XC+eq5wP8LrVfcU giXm6JZWmNTwvHBe6tMfjNhveEuIzV2v1+soyCnkA7Irk2sz4vLTD4s/HxMStNioVOGWITGaWkjeV cuuh8EscBFoH6hW4J8mzcvKiC; Received: from 97-118-117-21.hlrn.qwest.net ([97.118.117.21]:33660 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jJjr0-002Hpf-UT; Wed, 01 Apr 2020 14:20:51 -0600 From: Tom Tromey To: Pedro Alves Cc: Eli Zaretskii , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Consistently use BFD's time References: <20200114210956.25115-1-tromey@adacore.com> <20200114210956.25115-3-tromey@adacore.com> <83wo9s4sac.fsf@gnu.org> X-Attribution: Tom Date: Wed, 01 Apr 2020 14:20:50 -0600 In-Reply-To: (Pedro Alves's message of "Thu, 16 Jan 2020 20:37:28 +0000") Message-ID: <87sghnyn31.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.117.21 X-Source-L: No X-Exim-ID: 1jJjr0-002Hpf-UT X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-117-21.hlrn.qwest.net (murgatroyd) [97.118.117.21]:33660 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 20:22:25 -0000 >>>>> "Pedro" == Pedro Alves writes: [ system stat -vs- gnulib stat ] Pedro> I think that we need to: Pedro> - #undef stat before including bfd headers. Pedro> - Redefine it afterwards back to rpl_stat (*) Pedro> - add some kind of wrapper around bfd_stat (like maybe called gdb_bfd_stat) Pedro> that handles the mismatch. Something like: I read the thread again but I found it hard to figure out which alternative of the ones presented is preferred. Could you tell me which one it is? I'd like to update these patches and fix the caching bug as well. thanks, Tom