From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111374 invoked by alias); 18 Feb 2020 20:45:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111298 invoked by uid 89); 18 Feb 2020 20:45:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.8 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.1 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.160.12) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Feb 2020 20:45:17 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway30.websitewelcome.com (Postfix) with ESMTP id A14C551F0 for ; Tue, 18 Feb 2020 14:45:15 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 49k3jqATlSl8q49k3jWxkA; Tue, 18 Feb 2020 14:45:15 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1TWztO8uxmRq2srVC3tY7ym/y9HNAoGfH3cmQFtCJic=; b=xMYjXco2qrrynoPT7299ZLKpto vWSzJ3HKUkTKiwsDMGxl0R9poYf2PBGntEbGR9A91/KXfUK4KMD5P1yAGFW1neWQJoIX+Lsl6v2cD pAQ1zv0yP8A9APsipiImT9WZG; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:49096 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j49k3-001lb9-BO; Tue, 18 Feb 2020 13:45:15 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/5] gdb: change print format of flag enums with value 0 References: <20200213203035.30157-1-simon.marchi@efficios.com> <20200213203035.30157-5-simon.marchi@efficios.com> Date: Tue, 18 Feb 2020 20:45:00 -0000 In-Reply-To: <20200213203035.30157-5-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 13 Feb 2020 15:30:35 -0500") Message-ID: <87sgj762w5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00741.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> gdb/ChangeLog: Simon> * valprint.c (generic_val_print_enum_1): When printing a flag Simon> enum with value 0 and there is no enumerator with value 0, print Simon> just "0" instead of "(unknown: 0x0)". This looks reasonable. Thanks. Simon> /* We have a "flag" enum, so we try to decompose it into Simon> pieces as appropriate. A flag enum has disjoint Simon> constants by definition. */ I guess this comment is stale now, because an earlier patch changed it so that identical constants are allowed. Tom