* [PATCH] Fix search in TUI
[not found] <20191222140316.4044-1-ssbssa.ref@yahoo.de>
@ 2019-12-22 14:03 ` Hannes Domani via gdb-patches
2020-01-06 16:10 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Hannes Domani via gdb-patches @ 2019-12-22 14:03 UTC (permalink / raw)
To: gdb-patches
The variable last_line_listed is never set when print_source_lines_base is
called in TUI mode, so the search always started from the last line printed
outside of TUI mode.
gdb/ChangeLog:
2019-12-22 Hannes Domani <ssbssa@yahoo.de>
* source.c (print_source_lines_base): Set last_line_listed.
---
gdb/source.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdb/source.c b/gdb/source.c
index f5cd2a37e4..a6726f14c4 100644
--- a/gdb/source.c
+++ b/gdb/source.c
@@ -1232,6 +1232,7 @@ print_source_lines_base (struct symtab *s, int line, int stopline,
loc->set (s, line);
first_line_listed = line;
+ last_line_listed = line;
/* If printing of source lines is disabled, just print file and line
number. */
--
2.24.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix search in TUI
2019-12-22 14:03 ` [PATCH] Fix search in TUI Hannes Domani via gdb-patches
@ 2020-01-06 16:10 ` Tom Tromey
2020-01-06 16:18 ` Hannes Domani via gdb-patches
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2020-01-06 16:10 UTC (permalink / raw)
To: Hannes Domani via gdb-patches; +Cc: Hannes Domani
>>>>> "Hannes" == Hannes Domani via gdb-patches <gdb-patches@sourceware.org> writes:
Hannes> The variable last_line_listed is never set when print_source_lines_base is
Hannes> called in TUI mode, so the search always started from the last line printed
Hannes> outside of TUI mode.
Hannes> gdb/ChangeLog:
Hannes> 2019-12-22 Hannes Domani <ssbssa@yahoo.de>
Hannes> * source.c (print_source_lines_base): Set last_line_listed.
Thanks, this is ok.
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix search in TUI
2020-01-06 16:10 ` Tom Tromey
@ 2020-01-06 16:18 ` Hannes Domani via gdb-patches
0 siblings, 0 replies; 3+ messages in thread
From: Hannes Domani via gdb-patches @ 2020-01-06 16:18 UTC (permalink / raw)
To: Gdb-patches
Am Montag, 6. Januar 2020, 17:10:42 MEZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:
> >>>>> "Hannes" == Hannes Domani via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Hannes> The variable last_line_listed is never set when print_source_lines_base is
> Hannes> called in TUI mode, so the search always started from the last line printed
> Hannes> outside of TUI mode.
>
> Hannes> gdb/ChangeLog:
>
> Hannes> 2019-12-22 Hannes Domani <ssbssa@yahoo.de>
>
> Hannes> * source.c (print_source_lines_base): Set last_line_listed.
>
> Thanks, this is ok.
Pushed, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-06 16:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191222140316.4044-1-ssbssa.ref@yahoo.de>
2019-12-22 14:03 ` [PATCH] Fix search in TUI Hannes Domani via gdb-patches
2020-01-06 16:10 ` Tom Tromey
2020-01-06 16:18 ` Hannes Domani via gdb-patches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).