From: Tom Tromey <tom@tromey.com>
To: "Pedro Alves \(Code Review\)" <gerrit@gnutoolchain-gerrit.osci.io>
Cc: Tom Tromey <tromey@sourceware.org>,
gdb-patches@sourceware.org, gnutoolchain-gerrit@osci.io
Subject: Re: [review] Introduce fetch_pending_stop
Date: Thu, 21 Nov 2019 21:52:00 -0000 [thread overview]
Message-ID: <87sgmgganb.fsf@tromey.com> (raw)
In-Reply-To: <20191121184059.8611C2816F@gnutoolchain-gerrit.osci.io> (Pedro Alves's message of "Thu, 21 Nov 2019 13:40:59 -0500")
Pedro> | +bool
Pedro> | +fetch_pending_stop (bool debug_events, pending_stop *result)
Pedro> PS1, Line 326:
Pedro> I guess this could also be
Pedro> gdb::optional<pending_stop> fetch_pending_stop (bool debug_events, pending_stop *result)
Pedro> Just mentioning it for completeness, what you have is fine.
I went ahead & did this.
Tom
next prev parent reply other threads:[~2019-11-21 21:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 17:58 Tom Tromey (Code Review)
2019-11-21 18:41 ` Pedro Alves (Code Review)
2019-11-21 21:52 ` Tom Tromey [this message]
2019-11-26 17:12 Tom Tromey (Code Review)
2019-11-29 20:09 ` Pedro Alves (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgmgganb.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gnutoolchain-gerrit@osci.io \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).