From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62344 invoked by alias); 12 Feb 2019 17:08:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62327 invoked by uid 89); 12 Feb 2019 17:08:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:andrew., Youll, You'll X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.150.114) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Feb 2019 17:08:30 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 1966A2DC5A1 for ; Tue, 12 Feb 2019 11:08:29 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id tbXpgymjA4FKptbXpgJWHa; Tue, 12 Feb 2019 11:08:29 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XgaW6sBJsDEgXpa4A4fB5/2avXuL5KPBh+EXA/7qSgo=; b=C2vDbjL+FmM4FP7Kjfd8kUma0h 0R4iPq/Vdb+pl10YxihZNAEysBtTJSSeTgqYGuLg9OqfG/R2ZqTZNzs/J544BZAVFl53bIL773ABB vQ5g0IfuJtMLfWMh4YcpvIS23; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:60396 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gtbXo-003ZS3-Q3; Tue, 12 Feb 2019 11:08:28 -0600 From: Tom Tromey To: Andrew Burgess Cc: Joel Brobecker , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFC] Fix pager bugs with style output References: <20190209183721.3486-1-tom@tromey.com> <20190210123813.GA31881@adacore.com> <20190212135348.GY2829@embecosm.com> Date: Tue, 12 Feb 2019 17:08:00 -0000 In-Reply-To: <20190212135348.GY2829@embecosm.com> (Andrew Burgess's message of "Tue, 12 Feb 2019 13:53:48 +0000") Message-ID: <87sgwt6ik4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-02/txt/msg00157.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> I don't have a solution, but the issue here is that in Andrew> user_select_syms output is produced with printf_unfiltered, by passing Andrew> the line wrapping buffer, however, the symbol name is produced by a Andrew> call to ada_print_symbol_signature which uses fprintf_filtered, Andrew> placing the output into the line wrap buffer. Thanks for looking into this. Andrew> You'll need to reconcile these two things. Andrew> Given that ada_print_symbol_signature only seems to be called in areas Andrew> that are using unfiltered printing, simply changing Andrew> ada_print_symbol_signature to also use unfiltered printing should Andrew> provide a solution. How about having user_select_syms also use filtered output? That seems like it would be somewhat friendlier in the unlikely event that the menu was very long -- it would give the user a chance to read the choices. Tom