From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104100 invoked by alias); 23 Nov 2018 14:06:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104079 invoked by uid 89); 23 Nov 2018 14:06:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=liberty X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Nov 2018 14:06:28 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 60F0E309708F; Fri, 23 Nov 2018 14:06:27 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3193F17F3F; Fri, 23 Nov 2018 14:06:27 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: gdb-patches@sourceware.org, Rainer Orth Subject: Re: Breakage on builder Solaris11-amd64-m64, revision 080363310650c93ad8e93018bcb6760ba5d32d1c References: <96729b3f-3568-1d41-4bb8-fbe4d037da93@redhat.com> Date: Fri, 23 Nov 2018 14:06:00 -0000 In-Reply-To: <96729b3f-3568-1d41-4bb8-fbe4d037da93@redhat.com> (Pedro Alves's message of "Fri, 23 Nov 2018 13:34:01 +0000") Message-ID: <87sgzr6g7x.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00381.txt.bz2 On Friday, November 23 2018, Pedro Alves wrote: > On 11/22/2018 04:49 PM, gdb-buildbot@sergiodj.net wrote: >> Undefined first referenced >> symbol in file >> is_exited(ptid_t) procfs.o >> ld: fatal: symbol referencing errors >> collect2: error: ld returned 1 exit status >> gmake[2]: *** [Makefile:1912: gdb] Error 1 >> gmake[2]: Leaving directory '/opt/gdb-buildbot/home/solaris11-amd64/sola= ris11-amd64-m64/build/gdb' >> gmake[1]: *** [Makefile:8792: all-gdb] Error 2 >> gmake[1]: Leaving directory '/opt/gdb-buildbot/home/solaris11-amd64/sola= ris11-amd64-m64/build' >> gmake: *** [Makefile:849: all] Error 2 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > Whoops, sorry about that. I assume this works, but I haven't tried it. I took the liberty of running try builds with your patch on the Solaris builders: https://gdb-build.sergiodj.net/builders/Solaris11-amd64-m64/builds/410 https://gdb-build.sergiodj.net/builders/Solaris11-sparcv9-m64/builds/408 Unfortunately the build still fails with: ../../binutils-gdb/gdb/sol-thread.c: In member function =E2=80=98virtual = ptid_t sol_thread_target::wait(ptid_t, target_waitstatus*, int)=E2=80=99: ../../binutils-gdb/gdb/sol-thread.c:465:2: error: expected =E2=80=98)=E2= =80=99 before =E2=80=98{=E2=80=99 token { ^ ../../binutils-gdb/gdb/sol-thread.c:470:5: error: expected primary-expres= sion before =E2=80=98}=E2=80=99 token } ^ BTW, it's possible to run try builds on specific builders by using the "-b" option with "buildbot try". E.g.: buildbot try -b Solaris11-amd64-m64 -b Solaris11-sparcv9-m64 Thanks, > From a48ec78677f732cc78eeefecc149742eb4ca0624 Mon Sep 17 00:00:00 2001 > From: Pedro Alves > Date: Fri, 23 Nov 2018 13:13:35 +0000 > Subject: [PATCH] Fix Solaris build > > The recent commit 080363310650 ("Per-inferior thread list, thread > ranges/iterators, down with ALL_THREADS, etc.") removed the > definitions of is_running/is_stopped/is_exited but missed updating a > couple uses of is_exited in Solaris-specific code. > > gdb/ChangeLog: > 2018-11-23 Pedro Alves > > * procfs.c (procfs_notice_thread): Replace uses of > in_thread_list/is_exited with find_thread_ptid/THREAD_EXITED. > * sol-thread.c (sol_thread_target::wait) > (sol_update_thread_list_callback): Likewise. > --- > gdb/procfs.c | 3 ++- > gdb/sol-thread.c | 14 ++++++++------ > 2 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/gdb/procfs.c b/gdb/procfs.c > index 0d8f9df966..f82fc83987 100644 > --- a/gdb/procfs.c > +++ b/gdb/procfs.c > @@ -3133,7 +3133,8 @@ procfs_notice_thread (procinfo *pi, procinfo *threa= d, void *ptr) > { > ptid_t gdb_threadid =3D ptid_t (pi->pid, thread->tid, 0); >=20=20 > - if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid)) > + thread_info *thr =3D find_thread_ptid (gdb_threadid); > + if (thr =3D=3D NULL || thr->state =3D=3D THREAD_EXITED) > add_thread (gdb_threadid); >=20=20 > return 0; > diff --git a/gdb/sol-thread.c b/gdb/sol-thread.c > index 682302a40b..0a57c4d1a6 100644 > --- a/gdb/sol-thread.c > +++ b/gdb/sol-thread.c > @@ -462,9 +462,11 @@ sol_thread_target::wait (ptid_t ptid, struct target_= waitstatus *ourstatus, > /* See if we have a new thread. */ > if (rtnval.tid_p () > && rtnval !=3D save_ptid > - && (!in_thread_list (rtnval) > - || is_exited (rtnval))) > - add_thread (rtnval); > + { > + thread_info *thr =3D find_thread_ptid (rtnval); > + if (thr =3D=3D NULL || thr->state =3D=3D THREAD_EXITED) > + add_thread (rtnval); > + } > } >=20=20 > /* During process initialization, we may get here without the thread > @@ -1035,14 +1037,14 @@ sol_update_thread_list_callback (const td_thrhand= le_t *th, void *ignored) > { > td_err_e retval; > td_thrinfo_t ti; > - ptid_t ptid; >=20=20 > retval =3D p_td_thr_get_info (th, &ti); > if (retval !=3D TD_OK) > return -1; >=20=20 > - ptid =3D ptid_t (inferior_ptid.pid (), 0, ti.ti_tid); > - if (!in_thread_list (ptid) || is_exited (ptid)) > + ptid_t ptid =3D ptid_t (inferior_ptid.pid (), 0, ti.ti_tid); > + thread_info *thr =3D find_thread_ptid (ptid); > + if (thr =3D=3D NULL || thr->state =3D=3D THREAD_EXITED) > add_thread (ptid); >=20=20 > return 0; > --=20 > 2.14.4 --=20 Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/