From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix PR cli/23785: Check if file exists when invoking "restore FILE binary"
Date: Thu, 18 Oct 2018 21:40:00 -0000 [thread overview]
Message-ID: <87sh13vsqw.fsf@redhat.com> (raw)
In-Reply-To: <878t2var9d.fsf@tromey.com> (Tom Tromey's message of "Thu, 18 Oct 2018 15:17:50 -0600")
On Thursday, October 18 2018, Tom Tromey wrote:
>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> This simple patch fixes the segfault reported on PR cli/23785, which
> Sergio> happens when using the "restore FILE binary" command with a
> Sergio> non-existent file. We just have to check if the file handler returned
> Sergio> by "gdb_fopen_cloexec" is not NULL, and error out if it is.
>
> Sergio> A test has also been added to gdb.base/restore.exp in order to
> Sergio> exercise this scenario.
>
> Thanks, this is ok.
Thanks, pushed.
94c18618a8e29894a7b3104375e0510d71a568fb
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
prev parent reply other threads:[~2018-10-18 21:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 17:01 Sergio Durigan Junior
2018-10-18 21:18 ` Tom Tromey
2018-10-18 21:40 ` Sergio Durigan Junior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh13vsqw.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).