From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122667 invoked by alias); 26 Sep 2018 13:16:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122534 invoked by uid 89); 26 Sep 2018 13:16:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=bringing, Obviously X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Sep 2018 13:16:18 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EDE1A3001AB3; Wed, 26 Sep 2018 13:16:08 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id B4D945D6A9; Wed, 26 Sep 2018 13:16:08 +0000 (UTC) From: Sergio Durigan Junior To: Rainer Orth Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Provide Solaris 11 buildbots References: <874lelw9r3.fsf@redhat.com> <877ejguuo0.fsf@redhat.com> <87fty4teps.fsf@redhat.com> <871s9ote89.fsf@redhat.com> <875zyuq5pr.fsf@redhat.com> Date: Wed, 26 Sep 2018 13:16:00 -0000 In-Reply-To: <875zyuq5pr.fsf@redhat.com> (Sergio Durigan Junior's message of "Mon, 24 Sep 2018 11:24:00 -0400") Message-ID: <87sh1wwg9z.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00847.txt.bz2 On Monday, September 24 2018, I wrote: > On Monday, September 24 2018, Rainer Orth wrote: >> it seems we managed to mess up the configure flags badly here: right now >> the buildbots are configured with just CFLAGS/CXXFLAGS=-m64, nothing >> more. I hope the following patch should fix things: > > Ah, OK. I may have misunderstood the patch/requirements. I've now > simplified the configuration. > >> * There's no need for disable_default_compilation_flags = True: the >> default works just fine, we only need to add -O at the moment. Isn't >> it enough to do this once in RunTestGDBSolaris_Common? > > Yeah, it should be. > >> * Obviously the -m64 needs to be appended in RunTestGDBPlainSolaris_c64 >> to both CFLAGS and CXXFLAGS to avoid losing the -O above. > > Yeah. > >> * Not in the patch, but wouldn't it be enough to set enable_targets_all, >> make_command, and run_testsuite only once in RunTestGDBSolaris_Common? > > It turned out to be a bit more complicated. I'm in a hurry right now, > so I did a quick hack to make it work. I'll monitor the next builds. After this, the builds started to pass. Thanks for bringing this to my attention, Rainer. I'll enable the email notifications for both builders later today. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/