From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5982 invoked by alias); 31 Aug 2018 15:43:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5970 invoked by uid 89); 31 Aug 2018 15:43:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=nearby, Hx-languages-length:679 X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.123) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Aug 2018 15:43:54 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway32.websitewelcome.com (Postfix) with ESMTP id B830A10A24D3 for ; Fri, 31 Aug 2018 10:43:52 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vlZyfuNw9BcCXvlaFfO7le; Fri, 31 Aug 2018 10:43:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=e/tFRWMW6HrNw+J9XKoQ1/kOI9TqtxJ5Np0e4zlHQAE=; b=l3p93ZgQkQJrgxkv8SVOiw3Cb6 PQI0gXct4LofG++G5GtpIqfkbP4sekaT7zIXPnxbBMVcAorkMumenmhyCE4OhCuiwmOK8OW/8mIht Y45B/Yq4LzuXR8AvEA46tXCB7; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:58586 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fvlZx-000Ndy-VQ; Fri, 31 Aug 2018 10:43:22 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Eliminate target_have_continuable_watchpoint References: <20180831151159.10583-1-palves@redhat.com> <20180831151159.10583-2-palves@redhat.com> <871sae1rh9.fsf@tromey.com> Date: Fri, 31 Aug 2018 15:43:00 -0000 In-Reply-To: (Pedro Alves's message of "Fri, 31 Aug 2018 16:40:27 +0100") Message-ID: <87sh2uzgme.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00873.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> I think the comment just before this function should also be removed. Pedro> I thought it was still useful as is. It's describing x86 watchpoints Pedro> generically enough before a set of functions implementing watchpoints Pedro> support that I thought that it's still positioned in a good place as Pedro> is. WDYT? I looked at that but I didn't understand how the comment related to the nearby code; like I didn't see anything else in that file about the status register. However I think it's a minor point and if it makes sense to you it is fine. Tom