From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Pedro Alves <palves@redhat.com>,
Simon Marchi <simon.marchi@polymtl.ca>,
Joel Brobecker <brobecker@adacore.com>,
gdb-patches@sourceware.org
Subject: Re: [RFA 00/10] Remove standalone ptid functions
Date: Mon, 02 Jul 2018 15:00:00 -0000 [thread overview]
Message-ID: <87sh51of6q.fsf@tromey.com> (raw)
In-Reply-To: <87bmcde5nq.fsf@tromey.com> (Tom Tromey's message of "Thu, 14 Jun 2018 08:42:17 -0700")
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> I'm just not so sure about eliminating pid_to_ptid. I'd ran into uses
Pedro> of that where I had second thoughts on whether replacing it with
Pedro> a ptid_t ctor call is really a good idea. What I thought was,
Pedro> that when you're reading the code, a pid_to_ptid call more clearly shows
Pedro> that want to build a process-wide (sometimes a filter) ptid as opposed
Pedro> to a single thread ptid. It also helps with grepping, if you'd like
Pedro> to find such spots. But it's not a big deal, and I can certainly live
Pedro> with it.
Tom> It's easy enough to drop it out of the series if you would prefer that,
Tom> or to rename it to something like ptid_t::from_pid. Let me know.
Hi Pedro. This series is still pending since I was waiting for a reply
to this.
Tom
next prev parent reply other threads:[~2018-07-02 15:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 21:51 Tom Tromey
2018-06-13 21:51 ` [RFA 07/10] Remove ptid_lwp_p Tom Tromey
2018-06-13 21:51 ` [RFA 10/10] Remove ptid_equal Tom Tromey
2018-06-13 21:51 ` [RFA 05/10] Remove ptid_get_tid Tom Tromey
2018-06-13 21:51 ` [RFA 03/10] Remove ptid_get_pid Tom Tromey
2018-06-13 21:51 ` [RFA 06/10] Remove ptid_is_pid Tom Tromey
2018-06-13 21:51 ` [RFA 02/10] Remove pid_to_ptid Tom Tromey
2018-06-13 21:51 ` [RFA 09/10] Remove ptid_match Tom Tromey
2018-06-13 21:51 ` [RFA 08/10] Remove ptid_tid_p Tom Tromey
2018-06-13 21:51 ` [RFA 04/10] Remove ptid_get_lwp Tom Tromey
2018-06-13 21:51 ` [RFA 01/10] Remove ptid_build Tom Tromey
2018-06-13 23:22 ` [RFA 00/10] Remove standalone ptid functions Joel Brobecker
2018-06-14 2:04 ` Simon Marchi
2018-06-14 11:06 ` Pedro Alves
2018-06-14 15:42 ` Tom Tromey
2018-07-02 15:00 ` Tom Tromey [this message]
2018-07-03 13:54 ` Pedro Alves
2018-07-03 15:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh51of6q.fsf@tromey.com \
--to=tom@tromey.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).