From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106159 invoked by alias); 2 Jul 2018 15:00:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106145 invoked by uid 89); 2 Jul 2018 15:00:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=U*palves, sk:palves, sk:palves@, palvesredhatcom X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.95) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Jul 2018 15:00:50 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway21.websitewelcome.com (Postfix) with ESMTP id C75EF400D3D4B for ; Mon, 2 Jul 2018 10:00:46 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id a0Jqft8ZlaSeya0JqfXwxf; Mon, 02 Jul 2018 10:00:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ic99ZueCsiZEs+ZihknN9b+lhD72wCZQARhFzVF73AQ=; b=Er+ahi7ZVqka/m0etADw6/6NrB oc3n0odrG9y3qEZ1FjHkIN24jZZTzCVAMMLhE5QsvQ8oOTOkrpSocutch9J+Ue4BgfClpr77LAljM EU9ZWiRxKtdPCfoZa2h+t2T15; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:44206 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fa0Jq-0032PV-I8; Mon, 02 Jul 2018 10:00:46 -0500 From: Tom Tromey To: Tom Tromey Cc: Pedro Alves , Simon Marchi , Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [RFA 00/10] Remove standalone ptid functions References: <20180613215049.9691-1-tom@tromey.com> <20180613232228.GA2166@adacore.com> <49903166aff66528df83fbda26001be8@polymtl.ca> <64e82c8f-9647-2fb9-62f7-0b31660a41c6@redhat.com> <87bmcde5nq.fsf@tromey.com> Date: Mon, 02 Jul 2018 15:00:00 -0000 In-Reply-To: <87bmcde5nq.fsf@tromey.com> (Tom Tromey's message of "Thu, 14 Jun 2018 08:42:17 -0700") Message-ID: <87sh51of6q.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00011.txt.bz2 >>>>> "Tom" == Tom Tromey writes: >>>>> "Pedro" == Pedro Alves writes: Pedro> I'm just not so sure about eliminating pid_to_ptid. I'd ran into uses Pedro> of that where I had second thoughts on whether replacing it with Pedro> a ptid_t ctor call is really a good idea. What I thought was, Pedro> that when you're reading the code, a pid_to_ptid call more clearly shows Pedro> that want to build a process-wide (sometimes a filter) ptid as opposed Pedro> to a single thread ptid. It also helps with grepping, if you'd like Pedro> to find such spots. But it's not a big deal, and I can certainly live Pedro> with it. Tom> It's easy enough to drop it out of the series if you would prefer that, Tom> or to rename it to something like ptid_t::from_pid. Let me know. Hi Pedro. This series is still pending since I was waiting for a reply to this. Tom