From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26332 invoked by alias); 25 May 2018 17:34:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26267 invoked by uid 89); 25 May 2018 17:34:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=nail X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.141) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 May 2018 17:34:22 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 1F4E319BE6 for ; Fri, 25 May 2018 12:34:21 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id MGbdfbZ9HRPojMGbdfJQIm; Fri, 25 May 2018 12:34:21 -0500 X-Authority-Reason: nr=8 Received: from 174-29-44-154.hlrn.qwest.net ([174.29.44.154]:48162 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fMGbc-000mlI-TF; Fri, 25 May 2018 12:34:21 -0500 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 0/6] Make psymbols independent of the progspace References: <20180503223621.22544-1-tom@tromey.com> Date: Fri, 25 May 2018 17:58:00 -0000 In-Reply-To: <20180503223621.22544-1-tom@tromey.com> (Tom Tromey's message of "Thu, 3 May 2018 16:36:15 -0600") Message-ID: <87sh6fd4h0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fMGbc-000mlI-TF X-Source-Sender: 174-29-44-154.hlrn.qwest.net (pokyo) [174.29.44.154]:48162 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00689.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> This is another old patch series that I never checked in, which I've Tom> now rebased. Tom> Like some earlier series -- most recently for line tables -- This Tom> series changes partial symbols to be independent of the progspace. Tom> This means that the data is now stored unrelocated, and could in Tom> theory be shared across multiple objfiles. Tom> In practice psymtabs cannot be shared yet, because they have a Tom> backlink to the full symtab. Tom> Patches #1-#3 are just infrastructure changes in preparation for the Tom> main patch; and most of the real work is in patch #6. Tom> In patch #6 I chose to adjust addresses like this: Tom> lo = gdbarch_adjust_dwarf2_addr (gdbarch, lo + baseaddr) - baseaddr; Tom> I'm not sure if this is the best way. Maybe in the line table (I Tom> can't look at this moment and I don't recall offhand) patch I chose to Tom> pass unrelocated addresses to gdbarch_adjust_dwarf2_addr. It would be Tom> good to nail down the intended meaning of this hook and adjust Tom> accordingly. Tom> Tested by the buildbot -- but careful review is still required, Tom> because some of the changes are not tested there. Ping. Tom