From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12968 invoked by alias); 12 Nov 2014 15:05:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12957 invoked by uid 89); 12 Nov 2014 15:05:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp13.uk.ibm.com Received: from e06smtp13.uk.ibm.com (HELO e06smtp13.uk.ibm.com) (195.75.94.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 12 Nov 2014 15:05:11 +0000 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 12 Nov 2014 15:05:08 -0000 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 12 Nov 2014 15:05:05 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 3F4621B08069 for ; Wed, 12 Nov 2014 15:05:14 +0000 (GMT) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sACF55NY3670278 for ; Wed, 12 Nov 2014 15:05:05 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sACF548v018718 for ; Wed, 12 Nov 2014 08:05:04 -0700 Received: from br87z6lw.de.ibm.com (dyn-9-152-212-196.boeblingen.de.ibm.com [9.152.212.196]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id sACF54p4018674; Wed, 12 Nov 2014 08:05:04 -0700 From: Andreas Arnez To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 13/16] Drop non-prototype C function header variants: 'list' test case References: <1414597859-12523-1-git-send-email-arnez@linux.vnet.ibm.com> <1414598446-13831-13-git-send-email-arnez@linux.vnet.ibm.com> <5463538A.4090508@redhat.com> Date: Wed, 12 Nov 2014 15:05:00 -0000 In-Reply-To: <5463538A.4090508@redhat.com> (Pedro Alves's message of "Wed, 12 Nov 2014 12:33:14 +0000") Message-ID: <87sihoxxwf.fsf@br87z6lw.de.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14111215-0013-0000-0000-000001D3F902 X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00213.txt.bz2 On Wed, Nov 12 2014, Pedro Alves wrote: > On 10/29/2014 04:00 PM, Andreas Arnez wrote: >> Remove old-style function header variants from list0.h and list1.c. >> Fill the removed lines with comments or empty lines, such that the >> line numbering is undisturbed. > > Why is it important that the line numbering is undisturbed? Changes to the line numbering would require heavy adjustments to list.exp. Many line numbers are hard-coded, as well as a fair amount of knowledge about the source code in and around certain lines. Thus the dependency on the line numbering can not be eliminated so easily here, and it may not even be a useful goal for a "list" test case. Another option might be to adjust the literal line numbers in list.exp, but even that is not as straightforward as it may seem, since the test case expects certain source lines to be exactly n lines apart. I'll add the above explanation to the commit message, OK?