From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26172 invoked by alias); 25 Sep 2014 02:31:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26109 invoked by uid 89); 25 Sep 2014 02:31:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 25 Sep 2014 02:31:01 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8P2UtP7002805 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 24 Sep 2014 22:30:55 -0400 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8P2Utgx016233 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 24 Sep 2014 22:30:55 -0400 From: Sergio Durigan Junior To: Doug Evans Cc: Simon Marchi , gdb-patches Subject: Re: [PATCH] Don't prune program spaces when doing "maintenance info program-spaces" References: <1411582288-20967-1-git-send-email-simon.marchi@ericsson.com> X-URL: http://www.redhat.com Date: Thu, 25 Sep 2014 02:31:00 -0000 In-Reply-To: (Doug Evans's message of "Wed, 24 Sep 2014 15:48:38 -0700") Message-ID: <87sijgig81.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00721.txt.bz2 On Wednesday, September 24 2014, Doug Evans wrote: > IOW, how about move the call to prune_program_spaces to whatever > caller wants it. As a note, after I commented on the patch, I noticed that the "prune" argument may be unecessary indeed (and the "prunning" logic"), because we are not prunning anything anymore. Anyway, I just wanted to say that I agree with removing this part of the code, and moving it to more suitable parts. -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/