From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4691 invoked by alias); 13 Jan 2014 20:02:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4681 invoked by uid 89); 13 Jan 2014 20:02:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Jan 2014 20:02:49 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0DK2igl027396 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 13 Jan 2014 15:02:44 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0DK2fw1028118 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 13 Jan 2014 15:02:42 -0500 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH] rearrange struct value to save memory References: <1389294182-982-1-git-send-email-tromey@redhat.com> <52CF6966.1060405@codesourcery.com> Date: Mon, 13 Jan 2014 20:02:00 -0000 In-Reply-To: <52CF6966.1060405@codesourcery.com> (Yao Qi's message of "Fri, 10 Jan 2014 11:30:46 +0800") Message-ID: <87sisr1wgu.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00371.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> It does save some memory shown by the result of 'make perf-check' on Yao> an amd64-linux box. I don't see any time performance regression Yao> in the test. It is indeed a good improvement! Yao> Original Patched Yao> backtrace vmsize 2 55108 54316 Yao> backtrace vmsize 4 55108 52432 Yao> backtrace vmsize 8 53124 51512 [...] I tried perf-check out on another branch today. I didn't see a canned way to summarize the results, so I wrote the appended. You'll need a newish version of prettytable if you don't want the colorizing to mess up the table. This is still pretty dumb... I didn't try to deal with graphing or anything cool like that. Tom #!/usr/bin/python from termcolor import colored import re import fileinput import prettytable rx = re.compile('^(.*)\s([0-9.]+)$') # Allow 5% noise. NOISE = 0.05 results = {} for line in fileinput.input(): m = rx.match(line) if m: name = m.group(1) value = float(m.group(2)) if name not in results: results[name] = [] results[name].append(value) keys = results.keys() keys.sort() tab = prettytable.PrettyTable() for name in keys: vals = results[name] newvals = [name, str(vals[0])] for i in range(1, len(vals)): perc = abs((vals[i] - vals[i - 1]) / vals[i - 1]) nv = str(vals[i]) if perc > NOISE: if vals[i] > vals[i - 1]: nv = colored(nv, 'red') elif vals[i] < vals[i - 1]: nv = colored(nv, 'green') newvals.append(nv) tab.add_row(newvals) print tab