From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15681 invoked by alias); 9 Jan 2014 18:33:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15669 invoked by uid 89); 9 Jan 2014 18:33:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Jan 2014 18:33:48 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s09IXjT4003670 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 9 Jan 2014 13:33:45 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s09IXhaG003243 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 9 Jan 2014 13:33:45 -0500 From: Tom Tromey To: Iain Buclaw Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/5] Implement D primitive types in GDB References: Date: Thu, 09 Jan 2014 18:33:00 -0000 In-Reply-To: (Iain Buclaw's message of "Thu, 9 Jan 2014 13:11:31 +0000") Message-ID: <87sisx80oo.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00251.txt.bz2 >>>>> "Iain" == Iain Buclaw writes: Iain> D has it's own type system separate from C. This defines all Iain> primitive types all found in D. Thanks. I think the guts of this patch are fine, just some nits around the edges. Iain> +enum d_primitive_types { Comment before the new type. Iain> + d_primitive_type_cent, Iain> + d_primitive_type_ucent, I don't think we need a comment for each enum constant, but it would be nice for the ones that are "not obvious to C developers". Subjective I realize; but at least here I have no idea what "cent" means. Iain> + d_primitive_type_ifloat, Iain> + d_primitive_type_idouble, Iain> + d_primitive_type_ireal, Or what the "i" prefix means. Iain> + d_primitive_type_cfloat, Iain> + d_primitive_type_cdouble, Iain> + d_primitive_type_creal, "c" means complex maybe? Iain> +static void Iain> +d_language_arch_info (struct gdbarch *gdbarch, Iain> + struct language_arch_info *lai) Iain> +{ All new functions need intro comments. It's fine if they are short; in a case like this where the new function is the implementation of a language method, it can just mention which method it implements. Iain> +static void * Iain> +build_d_types (struct gdbarch *gdbarch) Iain> +{ Comment. Iain> +const struct builtin_d_type * Iain> +builtin_d_type (struct gdbarch *gdbarch) Iain> +{ Comment. Iain> +struct builtin_d_type Iain> +{ Comment. I think it's fine to refer readers back to the enum for the meaning of fields here. Iain> +# NOTE: The tests here intentionally do not require a go compiler. Cut-and-pasto :) Tom