* [PATCH] testsuite: skip morestack.exp in sparc targets
@ 2013-10-09 12:48 Jose E. Marchesi
2013-10-09 12:58 ` Will Newton
2013-10-10 18:31 ` Tom Tromey
0 siblings, 2 replies; 5+ messages in thread
From: Jose E. Marchesi @ 2013-10-09 12:48 UTC (permalink / raw)
To: gdb-patches
2013-10-09 Jose E. Marchesi <jose.marchesi@oracle.com>
* gdb.base/morestack.exp: Skip test in sparc targets, where
-fsplit-stack is not supported.
Index: testsuite/gdb.base/morestack.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/morestack.exp,v
retrieving revision 1.5
diff -u -r1.5 morestack.exp
--- testsuite/gdb.base/morestack.exp 27 Jun 2013 18:51:31 -0000 1.5
+++ testsuite/gdb.base/morestack.exp 9 Oct 2013 12:43:55 -0000
@@ -13,6 +13,12 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
+# This test does not work on targets for which -fsplit-stack is not
+# supported.
+if { [istarget sparc*-*-linux-gnu] } {
+ return
+}
+
if [get_compiler_info] {
return -1
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] testsuite: skip morestack.exp in sparc targets
2013-10-09 12:48 [PATCH] testsuite: skip morestack.exp in sparc targets Jose E. Marchesi
@ 2013-10-09 12:58 ` Will Newton
2013-10-09 13:03 ` Jose E. Marchesi
2013-10-10 18:31 ` Tom Tromey
1 sibling, 1 reply; 5+ messages in thread
From: Will Newton @ 2013-10-09 12:58 UTC (permalink / raw)
To: Jose E. Marchesi; +Cc: gdb-patches
On 9 October 2013 13:49, Jose E. Marchesi <jose.marchesi@oracle.com> wrote:
>
> 2013-10-09 Jose E. Marchesi <jose.marchesi@oracle.com>
>
> * gdb.base/morestack.exp: Skip test in sparc targets, where
> -fsplit-stack is not supported.
>
> Index: testsuite/gdb.base/morestack.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/morestack.exp,v
> retrieving revision 1.5
> diff -u -r1.5 morestack.exp
> --- testsuite/gdb.base/morestack.exp 27 Jun 2013 18:51:31 -0000 1.5
> +++ testsuite/gdb.base/morestack.exp 9 Oct 2013 12:43:55 -0000
> @@ -13,6 +13,12 @@
> # You should have received a copy of the GNU General Public License
> # along with this program. If not, see <http://www.gnu.org/licenses/>.
>
> +# This test does not work on targets for which -fsplit-stack is not
> +# supported.
> +if { [istarget sparc*-*-linux-gnu] } {
> + return
> +}
> +
> if [get_compiler_info] {
> return -1
> }
It might be simpler just to enable for the targets that do support
-fsplit-stack:
if { ![istarget i?86-*-*] && ![istarget x86_64-*-* ] } {
return
}
--
Will Newton
Toolchain Working Group, Linaro
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] testsuite: skip morestack.exp in sparc targets
2013-10-09 12:58 ` Will Newton
@ 2013-10-09 13:03 ` Jose E. Marchesi
0 siblings, 0 replies; 5+ messages in thread
From: Jose E. Marchesi @ 2013-10-09 13:03 UTC (permalink / raw)
To: Will Newton; +Cc: gdb-patches
> +# This test does not work on targets for which -fsplit-stack is not
> +# supported.
> +if { [istarget sparc*-*-linux-gnu] } {
> + return
> +}
> +
> if [get_compiler_info] {
> return -1
> }
It might be simpler just to enable for the targets that do support
-fsplit-stack:
if { ![istarget i?86-*-*] && ![istarget x86_64-*-* ] } {
return
}
Yes, much better. I wasn't sure about other archs :)
Could someone apply this change?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] testsuite: skip morestack.exp in sparc targets
2013-10-09 12:48 [PATCH] testsuite: skip morestack.exp in sparc targets Jose E. Marchesi
2013-10-09 12:58 ` Will Newton
@ 2013-10-10 18:31 ` Tom Tromey
2013-10-14 10:57 ` Jose E. Marchesi
1 sibling, 1 reply; 5+ messages in thread
From: Tom Tromey @ 2013-10-10 18:31 UTC (permalink / raw)
To: Jose E. Marchesi; +Cc: gdb-patches
Jose> 2013-10-09 Jose E. Marchesi <jose.marchesi@oracle.com>
Jose> * gdb.base/morestack.exp: Skip test in sparc targets, where
Jose> -fsplit-stack is not supported.
What is the current failure mode?
I think it would be better to feature-test the compiler rather than
adding a white- or black-list. The latter I think it possibly even
worse than an "unsupported" in the test results.
Tom
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] testsuite: skip morestack.exp in sparc targets
2013-10-10 18:31 ` Tom Tromey
@ 2013-10-14 10:57 ` Jose E. Marchesi
0 siblings, 0 replies; 5+ messages in thread
From: Jose E. Marchesi @ 2013-10-14 10:57 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
Jose> 2013-10-09 Jose E. Marchesi <jose.marchesi@oracle.com>
Jose> * gdb.base/morestack.exp: Skip test in sparc targets, where
Jose> -fsplit-stack is not supported.
What is the current failure mode?
It is actually "untested". I wrongly thought it was counting as a
failed test. At this point I think that the current behavior is good
enough. Sorry for the noise!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-14 10:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-09 12:48 [PATCH] testsuite: skip morestack.exp in sparc targets Jose E. Marchesi
2013-10-09 12:58 ` Will Newton
2013-10-09 13:03 ` Jose E. Marchesi
2013-10-10 18:31 ` Tom Tromey
2013-10-14 10:57 ` Jose E. Marchesi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).