From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 9917C3870896 for ; Wed, 8 May 2024 15:02:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9917C3870896 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9917C3870896 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715180534; cv=none; b=bFsmq39M/TGtVbUvcmM4Ho5/GcLwywQpZcPHEFkK9fxluDUYZIbptN4XkiwlEadIOgKEyYJ8YbC5ZSLpnsp16/0qwXbF5m0QeYEYln2P6aEMJF+jq6sh5HTbJA5tEIfxTQnm942kmLmKTkC2iKmFZgrWHcaaIv02gZx56voSs4g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715180534; c=relaxed/simple; bh=dC96Rt3hGT9o26ffCrcNF/3pEaB3xGVdL/zkb5L6fXI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=sDCbVORfXq7/3pBtamEtgCFtfUxMvNdCegHnIudd8GGKiezYclUH/5l5jrTtUFGmSMUbq+PsvKw1Ii5s71SIxGYOdvH/dqJ0zyZE2CJVG/Gu/f8k1NuKmHL+Y6oK2pJs6RoZa4FMQEVJYrVsb5YJ4SZMf4WVvK18gywD5Ywbgao= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6010a.ext.cloudfilter.net ([10.0.30.248]) by cmsmtp with ESMTPS id 4NdgsSKvwjfBA4io0s5HLp; Wed, 08 May 2024 15:02:04 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 4inzsfZ5XF4Xp4inzsYVqw; Wed, 08 May 2024 15:02:03 +0000 X-Authority-Analysis: v=2.4 cv=UpZlNfwB c=1 sm=1 tr=0 ts=663b93eb a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=TpHVaj0NuXgA:10 a=Qbun_eYptAEA:10 a=T_Alst9gAAAA:8 a=CCpqsmhAAAAA:8 a=vHgjqLU2JS9mPnflkBsA:9 a=DvZ5ixILWSEuw56YIEpp:22 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VnzNviw2GQnbc7uhrieMxAjC7EJz2QMoQ4nRmxH+Syg=; b=iTcQYwJCMoJ/uz0jplrgN/jNBr wpQciY66r7pBVkYIPxw8ukXYzDq77nO0vup+gyAC6DuBWIaS/KkwEW26+QiOUJwMC6rv4wJVnvLt6 NFDUJhuCGs2q53TptkmuF0uKV; Received: from 97-122-86-252.hlrn.qwest.net ([97.122.86.252]:45864 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1s4inz-000FPv-0I; Wed, 08 May 2024 09:02:03 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 02/34] Windows gdb: Eliminate global current_process.dr[8] global In-Reply-To: <20240507234233.371123-3-pedro@palves.net> (Pedro Alves's message of "Wed, 8 May 2024 00:42:01 +0100") References: <20240507234233.371123-1-pedro@palves.net> <20240507234233.371123-3-pedro@palves.net> X-Attribution: Tom Date: Wed, 08 May 2024 09:02:02 -0600 Message-ID: <87ttj873f9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.252 X-Source-L: No X-Exim-ID: 1s4inz-000FPv-0I X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-252.hlrn.qwest.net (murgatroyd) [97.122.86.252]:45864 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfIhUNElk5/Il1jbqiCp/GHqMA9zMhmZOMtk8FuPYmScvzcejJXPBSfkyWAxcJQ9z1jkMOr/2bZh0GjFHweC/qAyQ+Azlfv2mD+sOThT3iPqeIjhXdwMO lXNrHjkVJ57bgEYWAKfylAzqZEYhliU0pfHxmCt08979g3vXHUqXqcK0oOiGh1hkVDD1FEzKYEA6Kua8yDb2IeKJDOGdkcIrmKM= X-Spam-Status: No, score=-3014.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Pedro" == Pedro Alves writes: Pedro> This patch makes the Windows native target follow that model as well. This looks good to me, though I am not super confident in my ability to reason about it in the abstract. Pedro> I don't understand why would windows_nat_target::resume want to call Pedro> SetThreadContext itself. That duplicates things as it is currently Pedro> worrying about setting the debug registers as well. windows_continue Pedro> also does that, and windows_nat_target::resume always calls it. So Pedro> this patch simplifies windows_nat_target::resume too. FWIW when doing work on windows-nat, I found a number of little oddities, but generally just erred on the side of preserving them, since it wasn't always clear to me what the ramifications were. Your series is a welcome and long-overdue cleanup. Pedro> - /* Copy dr values from that thread. Pedro> - But only if there were not modified since last stop. Pedro> - PR gdb/2388 */ This was moved to https://sourceware.org/bugzilla/show_bug.cgi?id=9493 in the bugzilla migration. Anyway I'm wondering if you tried this example. It didn't seem to come with a test case. Tom