From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 815193858CDB for ; Thu, 4 Apr 2024 08:50:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 815193858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 815193858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712220650; cv=none; b=P9X38bPg9Bb0WDL6k65mWnxZqYAJ1QKcTl8+0/RqNp1+sfuN318v5ga0Kas4kPu3WyvIbPQ9MEajwjuOS8bNtXaUNTwuPUnnV9odB/AGAFFLNvTB/RbDYmz5uiwF6E8za6wh/skHsbbhvrGbkUnZrlx90Wzq0m6SVRkP9rVvvmk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712220650; c=relaxed/simple; bh=LKXHPerH5XKTgHIwC/FLx5HJpmls4Jr8d3TaGpkO6Yo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=DcO/Rj8z+YN/V0R6T0oX20c8KaCV7kL/Hy1LV6YkgPxUEibIT0JeKxG386eExuldzYblNC36dRtmoFodWQ654SI/yhRe09YUduk5DV+OXcKmT3mQ8E96EQ8Uy8+LMur8XhH6jGzg1XZaiEPL+JefURDtsQgSMYgvC1B/de6SgSU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712220646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ad20CFTSHWeTXDWI68qp7rHkYlhEpyXPbjDutuBYKKs=; b=Pb/iYjogrfNFQkLYeKjQpMsaGzJ4iXswoIAjo3aapsTNTzLNerXln5y63LFgWh5P4UoMIe dgOFGm75T6f2LdAodse0Imv7DM9fdn2pEdnDjJFDit0Gw9WJGLjLHlB08Rs2UBRmQeniYu T9yz5ToqIDVCePusBVrdc22avo+1xV8= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-38-lt5kJz-vNq-_3oPX2W7Q1A-1; Thu, 04 Apr 2024 04:50:44 -0400 X-MC-Unique: lt5kJz-vNq-_3oPX2W7Q1A-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a4455ae71fcso45641266b.3 for ; Thu, 04 Apr 2024 01:50:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712220643; x=1712825443; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ad20CFTSHWeTXDWI68qp7rHkYlhEpyXPbjDutuBYKKs=; b=DQL/vj7hx2bUjGb9rGTfdJr4qH8EUWB7BSyXOadS16uJK2GxRUBnJDIWphA87Dd/ne C2/BqMsf9jzOtbQ/hRDkcN3rmHS4fX+nDroQcQ8mzLQyWFszlqhQ1iDTzWX9Yu55GIBE +0qqxOB5aP1G970VtxSXBta4hxJS64rmgUYOcmtREAbPcyaXQ0s9QcSQTC3DBM/gnaT5 cACoGic1X8bJfCxo0FYh9ulQAQMGiHqp5amtldBJp3qXDh9AaTKx6vgg0jvc+6O1lhXb LcgO0I1nMB+X5aZ/e0fIUzyJAku5no/zaDoLpf49qFRuD0ogP+sY7B6xqyuF+m8Z4ccZ /d0A== X-Forwarded-Encrypted: i=1; AJvYcCUxEYLRSg+qkQF77SX0iDLQBprJV+paEmtT81Tig6h3/E00e7ReALYlCCAY1xjwovzmiAICuedeHnPWEBCjM3gEDCpHrtmdLluekw== X-Gm-Message-State: AOJu0Yzx9wHa8QHPtNYAwehArhhs6p0H7QT+S320p/4n48wI/1/YHAOl TSg0sjvK41tL+Hw65LTHiqFS098D2cMRMFYP4uDGLnw7iXaeU7xr02pPZU4aIo6wbHu78xc30rS 1bCi6FqWagM/pPJbmM7uXbDMbhpUU7SP2aPD3lK1neXSvcw7ftW7T0W8l9oQ= X-Received: by 2002:a17:906:6c8f:b0:a4e:e47:9ee7 with SMTP id s15-20020a1709066c8f00b00a4e0e479ee7mr1228293ejr.49.1712220642903; Thu, 04 Apr 2024 01:50:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFk+2oqHvE3d0/mAuZTOZdp/3/u1exaQfe7rdGptGrwZ+cdaUifA2lsN8u6yIJ0XWCwWHlofw== X-Received: by 2002:a17:906:6c8f:b0:a4e:e47:9ee7 with SMTP id s15-20020a1709066c8f00b00a4e0e479ee7mr1228278ejr.49.1712220642316; Thu, 04 Apr 2024 01:50:42 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id xg9-20020a170907320900b00a4e26570581sm8458947ejb.108.2024.04.04.01.50.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 01:50:42 -0700 (PDT) From: Andrew Burgess To: Alexandra =?utf-8?B?SMOhamtvdsOh?= , gdb-patches@sourceware.org Cc: ahajkova@redhat.com Subject: Re: [PATCH v3 2/2] remote.c: Make packet_ok return struct packet_result In-Reply-To: <20240329130059.363456-2-ahajkova@khirnov.net> References: <20240329130059.363456-1-ahajkova@khirnov.net> <20240329130059.363456-2-ahajkova@khirnov.net> Date: Thu, 04 Apr 2024 09:50:40 +0100 Message-ID: <87ttkh340v.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Alexandra H=C3=A1jkov=C3=A1 writes: > From: Alexandra H=C3=A1jkov=C3=A1 > > This allows to print the error message stored in a packet_result > to be easily used in the calling function. I think this sentence could be improved: This allows the error message stored in a packet_result to be easily printed in the calling function. With that fixed: Approved-By: Andrew Burgess Thanks, Andrew