From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1592B3858D38 for ; Tue, 19 Dec 2023 10:26:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1592B3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1592B3858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702981576; cv=none; b=XHsu9WBqr54uuKIur0T93U4HBrsdS0v1lk9p8mbXCgiqUNjtPYWNrczeoz1RNj8+oziUrhRDImD9JC8pDwaad1zXqquX/Q4qs4jU4SOqB+lQTG4LhsPr0VtL/E8XBt9odGbQ50vqv1i97IO6TPmjr09cCbDviHnDGaF0jg9kb9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702981576; c=relaxed/simple; bh=ii5IOCerBuRlOVpmkiCY74e0NdEBRxNgpJY7OB2ab9w=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=tkQTUVNlBV3owiwzC6tDJbXkHXo9YnRN01DtpfjnJqUqj7MRXjepezgt812QenlPkysyHHFRLsmjHXal1D1iOcQXORheEl1JxogZCXScQiYhNpibWISQhza3/+LSxrHQLgBG7GNLiRFlKempPEA35pXY/2ZKLJLawC7eQnVVEL8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702981574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ii5IOCerBuRlOVpmkiCY74e0NdEBRxNgpJY7OB2ab9w=; b=El2PlGk1DInQA8lUmO0Wa+k4K6TbAd7PvUMl0kzSSf2aoyc4rJb9lvQjJw37afUutsMbHg 2e+0OKZPcWYfiC43nF4rcaCnHeOQ76lRNx1HheOndoTD0p/5nLUDzNi8s/2LkWPEVTNBNF QndjeXC38w02jvU8ktJFtwSAzH4Uwrk= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-192-LAkxh4Y8PbCXbbbFDR1jTA-1; Tue, 19 Dec 2023 05:26:13 -0500 X-MC-Unique: LAkxh4Y8PbCXbbbFDR1jTA-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a233627e8a5so126805766b.1 for ; Tue, 19 Dec 2023 02:26:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702981572; x=1703586372; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7m2W/oM9mIpf5neFsaedjZX77T4bkAXGdzUofkHEXdE=; b=PgJAqDqJTMzQnOTL8ygaIxwXSaiEDd0vR3u3aMNpMF4kdxmyqrTHmHk7NJiomtUw/m yJ+Kpmi4U8z8CbEtatl6AhvkgS/Mm0sgDrw+FFHQaLiPoWpsi54WOyL4zFctrXdwJIBv 6p64TzEfaPc7rMdNX1/7HZ6cSZdzE4v8OHI2TW8LPHDIz42pgBYs8Oqi/PKtg4+5ot18 KnFEvcu32YPSYHFeL6/qEX4CLEAbpqs7V+aZwWdAg75wU9fIreqMZatCjZJu2NePCYkC 12WCzfgolqnCgxbiY2YQG89Amv0EDk9zPLpOpI5aBf5EdBBnqxWfdFrmzuviJ1VzIBnI QRgQ== X-Gm-Message-State: AOJu0YxLNON2CiGCvShn8fP7FnVog0pdD4VamKqC++V94bhvBVc9SHSC UKcPp1trRXrmh7LZmCmOWsmYu1GC3MqEb8DrcG+GepfIQmNRMoJLsYayc8uw4TKzIJ7jkma6bvN PXYbFVKo59kPQolDslVSUiQ== X-Received: by 2002:a17:907:7416:b0:a23:397c:faef with SMTP id gj22-20020a170907741600b00a23397cfaefmr1504680ejc.121.1702981571967; Tue, 19 Dec 2023 02:26:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IFJAMd8Tn4sFNi9elAvqzFlLQC05aYscUvTaacdtqm3XqfVkv/yjaCLSNVKord+d5GAjXOSzg== X-Received: by 2002:a17:907:7416:b0:a23:397c:faef with SMTP id gj22-20020a170907741600b00a23397cfaefmr1504674ejc.121.1702981571646; Tue, 19 Dec 2023 02:26:11 -0800 (PST) Received: from localhost (105.226.159.143.dyn.plus.net. [143.159.226.105]) by smtp.gmail.com with ESMTPSA id i14-20020a170906a28e00b00a2332116b3esm3565432ejz.152.2023.12.19.02.26.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 02:26:11 -0800 (PST) From: Andrew Burgess To: Tom Tromey , Hannes Domani Cc: "gdb-patches@sourceware.org" , Tom Tromey Subject: Re: [PATCH 11/14] Remove redundant check from tui_refresh_frame_and_register_information In-Reply-To: <871qbj5bjk.fsf@tromey.com> References: <20231217-tui-regs-cleanup-v1-0-67bd0ea1e8be@tromey.com> <20231217-tui-regs-cleanup-v1-11-67bd0ea1e8be@tromey.com> <1463654062.4443004.1702920741907@mail.yahoo.com> <871qbj5bjk.fsf@tromey.com> Date: Tue, 19 Dec 2023 10:26:10 +0000 Message-ID: <87ttoezdx9.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Hannes" =3D=3D Hannes Domani writes: > >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (tui_is_window_visible (DATA_WIN) >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 && (frame_info_changed_p || from_stack)= ) > > Hannes> Was the return value of tui_show_frame_info(fi) also useless? > > Yes, in the above, 'from_stack' is always true, so the value of > 'frame_info_changed_p' is immaterial. Except I think that's a bug in the original code. As your previous patch points out we already hook the register changed observer, so the only time that a register change will need this function to refresh the register display is if the frame was changed. If we're going to stop checking frame_info_changed_p then we might as well stop hooking gdb::observers::register_changed and just rely on the before prompt hook to update everything, right? Thanks, Andrew