From: Tom Tromey <tom@tromey.com>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Another fix for the mcore simulator
Date: Mon, 27 Nov 2023 13:06:18 -0700 [thread overview]
Message-ID: <87ttp7dkqt.fsf@tromey.com> (raw)
In-Reply-To: <20cefa11-9565-47f5-b1bc-bd90e8c428fc@gmail.com> (Jeff Law's message of "Sun, 26 Nov 2023 11:47:43 -0700")
>>>>> "Jeff" == Jeff Law <jeffreyalaw@gmail.com> writes:
Jeff> No doubt there's more 64 bit host issues in the mcore simulator. I
Jeff> can't justify chasing them all down preemptively. But I'll obviously
Jeff> continue to fault in fixes if/when the GCC testsuite shows a
Jeff> regression.
Jeff> OK for the trunk?
I don't have any issue with the patch, but I confess I don't understand
what the bug was or how the patch works.
Jeff> unsigned imm = IMM5;
Jeff> - unsigned long tmp = gr[RD];
Jeff> + uint32_t tmp = gr[RD];
IIUC gr is a uint32_t so this patch seems like it just removes a zero
extension and then a narrowing cast.
Anyway, if it helps, IMO that's enough.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-11-27 20:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 18:47 Jeff Law
2023-11-27 20:06 ` Tom Tromey [this message]
2023-11-28 5:46 ` Jeff Law
2023-11-28 15:09 ` Tom Tromey
2023-12-01 2:45 ` Jeff Law
2023-12-01 3:56 ` Tom Tromey
2023-12-01 14:27 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttp7dkqt.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).