From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id CE0973858C41 for ; Tue, 10 Oct 2023 19:49:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CE0973858C41 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-5009a.ext.cloudfilter.net ([10.0.29.176]) by cmsmtp with ESMTP id qEXZqmRrEnGhUqIjZqrWTR; Tue, 10 Oct 2023 19:49:37 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id qIjYqVCMeivKvqIjYqiA3I; Tue, 10 Oct 2023 19:49:36 +0000 X-Authority-Analysis: v=2.4 cv=R8oQpPdX c=1 sm=1 tr=0 ts=6525aad0 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=bhdUkHdE2iEA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=Isbpdn48c4y4YF8XvKsA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=89X8iG5GpTphw/ITlhhrQKj6UXwydqydIcepFcEgYqY=; b=V1QedMd0ZIcM/8g+8pCrARnPHb nPi5V0S0xNRlBhtgblKpN99J4hdQPf858n8fTbLBVFhuDd8g3cQ4MSLhvo0EO/QvIQIsa0t4G4aJL pmsc49Hi21Tczw5WKOmqCDz/p; Received: from 71-211-130-31.hlrn.qwest.net ([71.211.130.31]:53724 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1) (envelope-from ) id 1qqIjX-002Ti5-2N; Tue, 10 Oct 2023 13:49:35 -0600 From: Tom Tromey To: Abdul Basit Ijaz via Gdb-patches Cc: Abdul Basit Ijaz , simark@simark.ca, tom@tromey.com Subject: Re: [PATCH v3 2/4] gdb, types: Resolve pointer types dynamically References: <20230904222956.15203-1-abdul.b.ijaz@intel.com> <20230904222956.15203-3-abdul.b.ijaz@intel.com> X-Attribution: Tom Date: Tue, 10 Oct 2023 13:49:35 -0600 In-Reply-To: <20230904222956.15203-3-abdul.b.ijaz@intel.com> (Abdul Basit Ijaz via Gdb-patches's message of "Tue, 5 Sep 2023 00:29:54 +0200") Message-ID: <87ttqytfzk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.31 X-Source-L: No X-Exim-ID: 1qqIjX-002Ti5-2N X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-31.hlrn.qwest.net (murgatroyd) [71.211.130.31]:53724 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLV2Lt+wQj1dt6FJ6X9breytQF6jEp38xP7Hkhb3t/MQfL3Pa1eAZU4zqBpZrjCLkQmN9wpkXvZvXWnOTpckCaYLFmk1zoWl69ke44xhxxLckH2+kN+1 3pEBbS1t7lNb9kGiiguEnYDWHl9VQgmGEYu97DAHx2XdC73uH0cZaL67b1tF23N/kB4WClaAfBhJtcGa9Dw4jS7z5O2vI8JkJVY= X-Spam-Status: No, score=-3024.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Abdul Basit Ijaz via Gdb-patches writes: > - /* We only want to recognize references at the outermost level. */ > - if (top_level && type->code () == TYPE_CODE_REF) > + /* We only want to recognize references and pointers at the outermost > + level. */ > + if (top_level > + && (type->code () == TYPE_CODE_REF || type->code () == TYPE_CODE_PTR)) Pre-existing but I wonder why this code checks TYPE_CODE_REF and not TYPE_CODE_RVALUE_REF. > diff --git a/gdb/valprint.c b/gdb/valprint.c > index b65dda15c04..c71ae089f46 100644 > --- a/gdb/valprint.c > +++ b/gdb/valprint.c > @@ -1156,12 +1156,6 @@ value_check_printable (struct value *val, struct ui_file *stream, > return 0; > } > - if (type_not_associated (val->type ())) > - { > - val_print_not_associated (stream); > - return 0; > - } I don't really know anything about Fortran, so I don't know why this code was here in the first place, nor what its removal might mean. Could you say why this is being removed? Tom