From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCHv2 0/5] Fix using an exec file with target: prefix
Date: Mon, 02 Oct 2023 13:13:15 -0600 [thread overview]
Message-ID: <87ttr8zvlg.fsf@tromey.com> (raw)
In-Reply-To: <cover.1695909469.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Thu, 28 Sep 2023 15:00:39 +0100")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> - Patch #5 has been completely changed. Tom Tromey pointed me to a
Andrew> previous series of his which (a) never got merged, and (b)
Andrew> included a much better solution to this problem. I've pulled out
Andrew> just the part I need to resolve the issue in that patch.
I looked at my series again, and it's worse than the status quo in some
ways; for instance it requires opening a BFD before checking the cache.
But, like I mentioned elsewhere, I did seem to fix the gnulib stat
problem, which means a lot of that series is obsolete. I think you've
picked up the only remaining good bit, which is the use of bfd_stat in
reread_symbols.
So, I think this series is ok.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2023-10-02 19:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 14:22 [PATCH " Andrew Burgess
2023-09-27 14:22 ` [PATCH 1/5] gdb: some additional filename styling Andrew Burgess
2023-09-27 14:22 ` [PATCH 2/5] gdb: use archive name in warning when appropriate Andrew Burgess
2023-09-27 14:22 ` [PATCH 3/5] gdb: remove use of a static buffer for building error strings Andrew Burgess
2023-09-27 14:22 ` [PATCH 4/5] gdb: remove print_sys_errmsg Andrew Burgess
2023-09-28 12:06 ` Andrew Burgess
2023-09-27 14:22 ` [PATCH 5/5] gdb: fix reread_symbols when an objfile has target: prefix Andrew Burgess
2023-09-28 14:00 ` [PATCHv2 0/5] Fix using an exec file with " Andrew Burgess
2023-09-28 14:00 ` [PATCHv2 1/5] gdb: some additional filename styling Andrew Burgess
2023-09-28 14:00 ` [PATCHv2 2/5] gdb: use archive name in warning when appropriate Andrew Burgess
2023-09-28 14:00 ` [PATCHv2 3/5] gdb: remove use of a static buffer for building error strings Andrew Burgess
2023-09-28 14:00 ` [PATCHv2 4/5] gdb: remove print_sys_errmsg Andrew Burgess
2023-09-28 14:00 ` [PATCHv2 5/5] gdb: fix reread_symbols when an objfile has target: prefix Andrew Burgess
2023-09-28 18:17 ` Tom Tromey
2023-09-29 10:20 ` Andrew Burgess
2023-10-02 14:19 ` Tom Tromey
2023-10-02 16:05 ` Andrew Burgess
2023-10-02 17:00 ` Tom Tromey
2023-10-02 19:13 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttr8zvlg.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).