From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by sourceware.org (Postfix) with ESMTPS id 2166B3858D28 for ; Tue, 22 Aug 2023 16:43:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2166B3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd2c.google.com with SMTP id ca18e2360f4ac-79241bb5807so42805339f.0 for ; Tue, 22 Aug 2023 09:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1692722616; x=1693327416; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=pPPajpEJP+h3NBDul7/N0ayWq+LH/bRXKKau1/y49EQ=; b=QwkonnbX1hRYzyN2XLH89n1HmXmB004H1MGf8i39alfEBsQd2Fb9dd8gIpEEBbORaS 5H91+pEiJgMYiQ/kvcDkFqDPGinG6xLABWWSvU3xwJeWzbRPyw4wZ9BbY6RuhUmpYXgx co50FFUxcMxmkF7JONmBTu1+Y2dMMkKC5YTH8AawXEAkm/S8IDT1L15agG9lBbjkZvIJ uY7Kp7er4agzROwpVPuVZ2WfT2q6sE/x4iroKFBJtprduZm7k9VBUc/FSbCiT/nlfnT1 NDrjplg4CEJ+vX4kqTxQX8G46kkVq6O+9pDvcJrNJE0CRqm/MumDrzA6/q8fkw6LltTm F92Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692722616; x=1693327416; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pPPajpEJP+h3NBDul7/N0ayWq+LH/bRXKKau1/y49EQ=; b=hmGyHFNooIh78Ocs4cjPoS5LK0XLggtzr/RAY9zb5HaqdXzaOdOs0/14UkfRZQ6SZW 5wAnLqFw1j2al6SrxoY+T9ogIqP7//V7R9BJGZAfxtFXin5sMd9QzG2xZjCFM/tYTkmG a70Trtnd0jhaZ21ahQmO3A3v5naQRyAG3VnJgaY3GAxAUdX6KnFsDbn27icnZ7PTiJg1 QvttFPyQd8Z/dfMizSUKwmJvo1lZCtpR0azKg5SHapWA0e7mSFL1Q8Bq17Vz7gj6LqvQ LMssYBqY2KzLqSzLr6jlV8D4Sa6DUaeD2FWfrtIafr/sU8D94Gr91KHPFuc70gqzDFRq QVwQ== X-Gm-Message-State: AOJu0YwL3mH9kgqsrHf8T3Rn9E2/3X0cfZ0mxbhvzU+aZG0d3Q8s7BY+ uiV7uoce6gXYc5fxt77orInlbaMCrGT2BzX56GmzUg== X-Google-Smtp-Source: AGHT+IG4kYWxqJCNpIMY3rk5R4oUcDFOUIrY9+cgQYwd9XwYb+Puy7+NlGWRye8Z8HkNMOY1dtxPwQ== X-Received: by 2002:a6b:620d:0:b0:790:cb89:44eb with SMTP id f13-20020a6b620d000000b00790cb8944ebmr284310iog.1.1692722616435; Tue, 22 Aug 2023 09:43:36 -0700 (PDT) Received: from murgatroyd (75-166-142-177.hlrn.qwest.net. [75.166.142.177]) by smtp.gmail.com with ESMTPSA id n13-20020a6b590d000000b0078647b08ab0sm3379231iob.6.2023.08.22.09.43.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Aug 2023 09:43:35 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Remove value::copy call from gdbpy_get_varobj_pretty_printer References: <20230804140022.4094630-1-tromey@adacore.com> X-Attribution: Tom Date: Tue, 22 Aug 2023 10:43:35 -0600 In-Reply-To: <20230804140022.4094630-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Fri, 4 Aug 2023 08:00:22 -0600") Message-ID: <87ttsruix4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> I noticed a call to value::copy in gdbpy_get_varobj_pretty_printer, Tom> and I couldn't figure out why it was there. I think maybe it came Tom> from the time when value_to_value_object would release values from the Tom> value chain -- but that was removed in commit f3d3bbbc. Tom> This patch removes this call. Regression tested on x86-64 Fedora 36. I'm checking this in. Tom