From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 79D8E3858D32 for ; Thu, 10 Aug 2023 16:18:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 79D8E3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id B8BC610043BCE for ; Thu, 10 Aug 2023 16:18:47 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id U8N5qjz3VMOiZU8N5qCVqC; Thu, 10 Aug 2023 16:18:47 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=TaZTCTch c=1 sm=1 tr=0 ts=64d50de7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=WtTqMusMvXL7R-DN_44A:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PIh2F9qRqUr7mHG1OZdLtjNxvnhCtXvCkETaY6l1mH4=; b=A+UaliinGLPXtWJAvLyBjvCI2E uU3MfVhTpphCGD09U1VZjoyvoj4TWgs2IHYagG1uH/oxiZIRhx9miz26hIr+j6NHp0iDW+tQ/THFE wgehFtvvJmsirKMi3JDJd0vX1; Received: from 71-211-152-221.hlrn.qwest.net ([71.211.152.221]:39308 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qU8N5-000otV-0t; Thu, 10 Aug 2023 10:18:47 -0600 From: Tom Tromey To: "Ijaz, Abdul B via Gdb-patches" Cc: Tom Tromey , "Ijaz, Abdul B" , "JiniSusan.George@amd.com" , "eliz@gnu.org" , "blarsen@redhat.com" Subject: Re: [PATCH v4 1/4] gdb, dwarf: add support for DW_AT_trampoline in DWARF reader References: <20230801224744.24433-1-abdul.b.ijaz@intel.com> <20230801224744.24433-2-abdul.b.ijaz@intel.com> <87ttthciei.fsf@tromey.com> X-Attribution: Tom Date: Thu, 10 Aug 2023 10:18:46 -0600 In-Reply-To: (Abdul B. via Gdb-patches Ijaz's message of "Mon, 7 Aug 2023 13:36:45 +0000") Message-ID: <87ttt63m6x.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.152.221 X-Source-L: No X-Exim-ID: 1qU8N5-000otV-0t X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-152-221.hlrn.qwest.net (murgatroyd) [71.211.152.221]:39308 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3018.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom> I didn't realize this until starting to read patch 2, but it seems Tom> strange to use the name here. It seems to me it would be better to Tom> use the address attached to the referenced subroutine DIE > For this case of value of attributes for this DIE may contain mangled > name of the target. So for such cases we are preferring the linkage > name to store. Shouldn't it cover such issues. Otherwise let me know > then I may update accordingly. > As per dwarf spec: " > If the value is of class string, then the value is the (possibly mangled) name of the target subprogram. > " The case I was referring to is the one where the attribute is a reference to another DIE: > + else if (attr->form_is_ref ()) And here, DWARF 5 says: If the value is of class reference, then the value specifies the debugging information entry of the target subprogram. That is, the attribute references the subprogram DIE directly, so it seems like using the name should not be needed. Tom